Update installation.rst #306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds updated rascaline-torch installation instructions
Luthaf
reviewed
May 29, 2024
| @@ -124,7 +124,7 @@ Building from source: | |||
| pip install --upgrade pip | |||
|
|
|||
| # alternatively, the same thing in a single command | |||
| pip install git+https://github.com/luthaf/rascaline#subdirectory=python/rascaline-torch | |||
| pip install --extra-index-url https://download.pytorch.org/whl/cpu git+https://github.com/luthaf/rascaline#subdirectory=python/rascaline-torch | |||
There was a problem hiding this comment.
This is not always necessary, and some people might want to install the cuda version of torch. A better solution here would be to do something like the metatensor docs: https://docs.metatensor.org/latest/installation.html#install-torch (the paragraph starting with "By default, PyTorch is installed with CUDA …")
There was a problem hiding this comment.
okay, sure, but as is this recommended install will fail on all machines that do not have CUDA installed which is usually the case
There was a problem hiding this comment.
I mean, people should be able to read 4 lines of text before blindly copy/pasting an installation command =). This will also be less of an issue when we do a full release on PyPI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds updated rascaline-torch installation instructions
📚 Documentation preview 📚: https://rascaline--306.org.readthedocs.build/en/306/