Improve handling of git info in version number #348
Conversation
Luthaf
force-pushed
the
better-dev-version
branch
4 times, most recently
from
4d873ad to
62b1197
Compare
Luthaf
force-pushed
the
better-dev-version
branch
2 times, most recently
from
0714b3e to
556923a
Compare
Luthaf
force-pushed
the
better-dev-version
branch
2 times, most recently
from
698924f to
0f36ab2
Compare
Luthaf
force-pushed
the
better-dev-version
branch
4 times, most recently
from
a522d42 to
f006875
Compare
Luthaf
force-pushed
the
better-dev-version
branch
2 times, most recently
from
6427dd2 to
db08514
Compare
|
|
Luthaf
force-pushed
the
better-dev-version
branch
5 times, most recently
from
f64bb23 to
c06df2f
Compare
The version is now automatically increased from the previous release when building a dev version. The full code hash is also included to find which exact version of the code was used after an installation from a git checkout
Luthaf
force-pushed
the
better-dev-version
branch
from
c06df2f to
96e8fe1
Compare
delocate now checks it more explictly
Luthaf
force-pushed
the
better-dev-version
branch
from
96e8fe1 to
eb502fd
Compare
|
|
||
| set(URL_ROOT "https://github.com/lab-cosmo/metatensor/releases/download") | ||
| include(FetchContent) | ||
| FetchContent_Declare( | ||
| metatensor_torch | ||
| URL ${URL_ROOT}/metatensor-torch-v${METATENSOR_FETCH_VERSION}/metatensor-torch-cxx-${METATENSOR_FETCH_VERSION}.tar.gz | ||
| URL_HASH SHA256=f050743662ece38948b2087dd025d60110645716840dbfc5370c059e1275d0cf | ||
| URL_HASH SHA256=0941da4bc6d25ee73b597774d3c8c6edf6a44f134139bd93b33834eae52ac4dd |
There was a problem hiding this comment.
We should maybe document somewhere what to do when lifting the metatensor version.
Including updating the hashes etc...
There was a problem hiding this comment.
I mean, if you update the version number above and not this, then CMake will yell at you. But yeah, we should add documentation around this!
There was a problem hiding this comment.
I added some comments in the CMakeLists.txt, should be good for now!
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "featomic" | |||
| version = "0.1.0" | |||
| version = "0.0.0" | |||
There was a problem hiding this comment.
Next version is -0.1.0? xD
There was a problem hiding this comment.
yep =D
The first release might actually be something like 0.6.0 (to indicate the actual level of maturity).
The version is now automatically increased from the previous release when building a dev version. The full code hash is also included, which prevents pip from caching a wheel during development without having to use uuid in the
file://URL. Removing uuid means that we can now install featomic withuv pip install.Still TBD:
Part of #281
📚 Documentation preview 📚: https://featomic--348.org.readthedocs.build/en/348/
⚙️ Download Python wheels for this pull-request (you can install these with pip)