Merge featomic and featomic-c-api #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luthaf
force-pushed
the
merge-c-api
branch
8 times, most recently
from
8a3fc11 to
7b12e3f
Compare
This allow to disable the chemfiles dependency by default for the rust crate. This makes examples in C and C++ a bit more complex, but also a lot closer to how someone would actually use the code from these languages.
This will make it easier to distirbute a single source archive containing everything. featomic-c-api is now the `c-api` module in featomic, enabled by the `c-api` cargo feature.
PicoCentauri
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to create a single archive containing all the relevant sources, to be included in the sdist for the python package.
This is part of #281
📚 Documentation preview 📚: https://featomic--349.org.readthedocs.build/en/349/
⚙️ Download Python wheels for this pull-request (you can install these with pip)