Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to windows-2022 #368

Merged
merged 1 commit into from
Jan 8, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/build-wheels.yml
Original file line number Diff line number Diff line change
@@ -48,7 +48,7 @@ jobs:
rust-target: aarch64-apple-darwin
cibw-arch: arm64
- name: x86_64 Windows
os: windows-2019
os: windows-2022
rust-target: x86_64-pc-windows-msvc
cibw-arch: AMD64
steps:
@@ -105,13 +105,13 @@ jobs:
matrix:
torch-version: ['2.1', '2.2', '2.3', '2.4', '2.5']
arch: ['arm64', 'x86_64']
os: ['ubuntu-22.04', 'macos-13', 'macos-14', 'windows-2019']
os: ['ubuntu-22.04', 'macos-13', 'macos-14', 'windows-2022']
exclude:
# remove mismatched arch for macOS
- {os: macos-14, arch: x86_64}
- {os: macos-13, arch: arm64}
# no arm64-windows build
- {os: windows-2019, arch: arm64}
- {os: windows-2022, arch: arm64}
# arch x86_64 on macos is only supported for torch <2.3
- {os: macos-13, arch: x86_64, torch-version: '2.3'}
- {os: macos-13, arch: x86_64, torch-version: '2.4'}
@@ -139,7 +139,7 @@ jobs:
rust-target: aarch64-apple-darwin
cibw-arch: arm64
- name: x86_64 Windows
os: windows-2019
os: windows-2022
arch: x86_64
rust-target: x86_64-pc-windows-msvc
cibw-arch: AMD64
@@ -237,7 +237,7 @@ jobs:
os: macos-14
arch: arm64
- name: x86_64 Windows
os: windows-2019
os: windows-2022
arch: x86_64
steps:
- uses: actions/checkout@v4
2 changes: 1 addition & 1 deletion .github/workflows/python-tests.yml
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@ jobs:
python-version: "3.12"
- os: macos-14
python-version: "3.12"
- os: windows-2019
- os: windows-2022
python-version: "3.12"
steps:
- uses: actions/checkout@v4
6 changes: 3 additions & 3 deletions .github/workflows/rust-tests.yml
Original file line number Diff line number Diff line change
@@ -53,7 +53,7 @@ jobs:
build-type: debug
working-directory: /Users/runner/work/featomic/featomic/

- os: windows-2019
- os: windows-2022
rust-version: stable
rust-target: x86_64-pc-windows-msvc
build-type: debug
@@ -82,13 +82,13 @@ jobs:
run: git config --global --add safe.directory /__w/featomic/featomic

- name: "copy the code to C: drive"
if: matrix.os == 'windows-2019'
if: matrix.os == 'windows-2022'
run: cp -r ${{ github.workspace }} ${{ matrix.working-directory }}
working-directory: /

- name: setup Python
uses: actions/setup-python@v5
if: "!matrix.container"
if: !matrix.container
with:
python-version: "3.12"

2 changes: 1 addition & 1 deletion .github/workflows/torch-tests.yml
Original file line number Diff line number Diff line change
@@ -42,7 +42,7 @@ jobs:
python-version: "3.12"
cargo-test-flags: --release

- os: windows-2019
- os: windows-2022
# Torch 2.3.0 is broken on Windows, and 2.2 has https://github.com/pytorch/pytorch/issues/118862
torch-version: 2.1.*
python-version: "3.11"