-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Equivariant powerspectrum by pair #378
Conversation
…g_product calculator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some torch tests and docs and changelog :)
python/featomic/tests/clebsch_gordan/equivariant_power_spectrum_by_pair.py
Outdated
Show resolved
Hide resolved
python/featomic/tests/clebsch_gordan/equivariant_power_spectrum_by_pair.py
Outdated
Show resolved
Hide resolved
python/featomic/featomic/clebsch_gordan/_equivariant_power_spectrum_by_pair.py
Outdated
Show resolved
Hide resolved
python/featomic/featomic/clebsch_gordan/_equivariant_power_spectrum_by_pair.py
Outdated
Show resolved
Hide resolved
python/featomic/featomic/clebsch_gordan/_equivariant_power_spectrum_by_pair.py
Outdated
Show resolved
Hide resolved
python/featomic/featomic/clebsch_gordan/_equivariant_power_spectrum_by_pair.py
Outdated
Show resolved
Hide resolved
python/featomic/featomic/clebsch_gordan/_equivariant_power_spectrum_by_pair.py
Outdated
Show resolved
Hide resolved
python/featomic/featomic/clebsch_gordan/_equivariant_power_spectrum_by_pair.py
Outdated
Show resolved
Hide resolved
python/featomic/featomic/clebsch_gordan/_equivariant_power_spectrum_by_pair.py
Outdated
Show resolved
Hide resolved
python/featomic/featomic/clebsch_gordan/_equivariant_power_spectrum_by_pair.py
Outdated
Show resolved
Hide resolved
…m_by_pair.py Co-authored-by: Joseph W. Abbott <[email protected]>
…m_by_pair.py Co-authored-by: Joseph W. Abbott <[email protected]>
…ctrum_by_pair.py Co-authored-by: Joseph W. Abbott <[email protected]>
…ctrum_by_pair.py Co-authored-by: Joseph W. Abbott <[email protected]>
…ctrum_by_pair.py Co-authored-by: Joseph W. Abbott <[email protected]>
…ctrum_by_pair.py Co-authored-by: Joseph W. Abbott <[email protected]>
…ctrum_by_pair.py Co-authored-by: Joseph W. Abbott <[email protected]>
…ctrum_by_pair.py Co-authored-by: Joseph W. Abbott <[email protected]>
…ctrum_by_pair.py Co-authored-by: Joseph W. Abbott <[email protected]>
…ctrum_by_pair.py Co-authored-by: Joseph W. Abbott <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thanks! Just a few comments :)
python/featomic/featomic/clebsch_gordan/_equivariant_power_spectrum_by_pair.py
Show resolved
Hide resolved
python/featomic/featomic/clebsch_gordan/_equivariant_power_spectrum_by_pair.py
Outdated
Show resolved
Hide resolved
python/featomic/featomic/clebsch_gordan/_equivariant_power_spectrum_by_pair.py
Outdated
Show resolved
Hide resolved
python/featomic/tests/clebsch_gordan/equivariant_power_spectrum_by_pair.py
Show resolved
Hide resolved
…ctrum_by_pair.py Co-authored-by: Joseph W. Abbott <[email protected]>
The tests will need metatensor/metatensor#839 to pass. |
Fixes #375
Implementation of
EquivariantPowerSpectrumByPair
📚 Download documentation for this pull-request