Skip to content

Commit

Permalink
refactor(sdk,gate)!: improve temporal rt (#642)
Browse files Browse the repository at this point in the history
Improve the temporal runtime exposing more parameters and adding more
tests.

#### Motivation and context

MET-397. The old implementation was bug-ridden and did not expose
necessary params.

#### Migration notes

API changes to `TemporalRuntime` ctor, methods and generated
materializers.

### Checklist

- [x] The change come with new or modified tests
- [ ] Hard-to-understand functions have explanatory comments
- [x] End-user documentation is updated to reflect the change
  • Loading branch information
Yohe-Am authored Apr 3, 2024
1 parent 1c6c8af commit b48d719
Show file tree
Hide file tree
Showing 30 changed files with 2,045 additions and 1,267 deletions.
262 changes: 5 additions & 257 deletions .ghjk/deno.lock

Large diffs are not rendered by default.

26 changes: 25 additions & 1 deletion .ghjk/lock.json
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,11 @@
"depConfigs": {},
"portRef": "[email protected]"
},
"1c1870c8d78ff6ec1621711218174deb5ddb2b4133b30d390dda5fa223978dba": {
"version": "v0.10.7",
"depConfigs": {},
"portRef": "[email protected]"
},
"f6c92b4425a3c13dfde7fe516efd376287e66cfa74aefd7b6a7a7bb0f3547a47": {
"version": "0.116.0",
"depConfigs": {
Expand Down Expand Up @@ -344,7 +349,7 @@
"portRef": "[email protected]"
},
"076a5b8ee3bdc68ebf20a696378458465042bb7dc1e49ac2dc98e5fa0dab3e25": {
"version": "3.6.2",
"version": "3.7.0",
"depConfigs": {
"cpy_bs_ghrel": {
"version": "3.12.1",
Expand Down Expand Up @@ -417,6 +422,7 @@
"d4ca252ebf5bda1d22a1a8a796e7d934f9cece3a",
"c0203b644293bdb58cac21fba277ef58a175ad67",
"98e6699973c2da514713908660702cfbfd49e14c",
"f8b685b18a2bb55787741eec84f2be5b672b1953",
"5ba4e48fe13b264e586f7bc2ca68f4649144d96f",
"55cf0ca40c7c1e3af02695285123eb94588c6f8a",
"386645977375df0d8f7ada7da257fee2113a1ed4",
Expand Down Expand Up @@ -556,6 +562,24 @@
"moduleSpecifier": "https://raw.githubusercontent.com/metatypedev/ghjk/423d38/ports/cargo-binstall.ts"
}
},
"f8b685b18a2bb55787741eec84f2be5b672b1953": {
"version": "0.10.7",
"port": {
"ty": "denoWorker@v1",
"name": "temporal_cli_ghrel",
"platforms": [
"aarch64-linux",
"x86_64-linux",
"aarch64-darwin",
"x86_64-darwin",
"aarch64-windows",
"x86_64-windows"
],
"version": "0.1.0",
"deps": [],
"moduleSpecifier": "https://raw.githubusercontent.com/metatypedev/ghjk/423d38/ports/temporal_cli.ts"
}
},
"5ba4e48fe13b264e586f7bc2ca68f4649144d96f": {
"version": "0.116.0",
"depConfigs": {
Expand Down
40 changes: 3 additions & 37 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -232,43 +232,6 @@ jobs:
- self-hosted # https://check-jsonschema.readthedocs.io/en/latest/faq.html#using-self-hosted-runners
- custom-ubuntu-large
timeout-minutes: 60
services:
redis:
image: bitnami/redis:7.0
env:
REDIS_PASSWORD: password
ports:
- 6379:6379
options: >-
--health-cmd "redis-cli -a password ping"
--health-interval 10s
--health-timeout 5s
--health-retries 5
postgres:
image: postgres:15
env:
POSTGRES_DB: db
POSTGRES_USER: postgres
POSTGRES_PASSWORD: password
ports:
- 5432:5432
options: >-
--health-cmd pg_isready
--health-interval 10s
--health-timeout 5s
--health-retries 5
minio:
image: bitnami/minio:2022
env:
MINIO_REGION_NAME: local
MINIO_ROOT_USER: minio
MINIO_ROOT_PASSWORD: password
MINIO_DEFAULT_BUCKETS: "bucket:none"
ports:
- "9000:9000"
- "9001:9001"
env:
DENO_DIR: deno-dir
steps:
- uses: actions/checkout@v4
- uses: dsherret/rust-toolchain-file@v1
Expand Down Expand Up @@ -324,6 +287,9 @@ jobs:
rm -rf typegraph/python/typegraph/gen
poetry run python -m wasmtime.bindgen $WASM_FILE --out-dir typegraph/python/typegraph/gen
# start the docker containers
deno run -A dev/env.ts base s3 prisma
# from old test-typegraph-core
# test in native rust, not in wasm for a future rust SDK
# without --tests, the --doc is causing a link error "syntax error in VERSION script"
Expand Down
Loading

0 comments on commit b48d719

Please sign in to comment.