Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gate): add err msg for missing env vars #827

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

destifo
Copy link
Contributor

@destifo destifo commented Sep 2, 2024

Migration notes

...

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@destifo destifo self-assigned this Sep 2, 2024
@destifo destifo changed the title refactor: add err msg for missing env vars refactor(gate): add err msg for missing env vars Sep 2, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.84%. Comparing base (6706680) to head (d473a06).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/typegate/src/config/types.ts 93.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
+ Coverage   75.75%   75.84%   +0.08%     
==========================================
  Files         144      144              
  Lines       16715    16715              
  Branches     1637     1640       +3     
==========================================
+ Hits        12663    12677      +14     
+ Misses       4029     4015      -14     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@michael-0acf4 michael-0acf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Natoandro
Natoandro previously approved these changes Sep 5, 2024
Natoandro
Natoandro previously approved these changes Sep 9, 2024
@destifo destifo merged commit 8da5053 into main Sep 9, 2024
14 checks passed
@destifo destifo deleted the refactor/improve-missing-env-var-err branch September 9, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants