Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove prisma count #916

Merged
merged 4 commits into from
Nov 13, 2024
Merged

fix: Remove prisma count #916

merged 4 commits into from
Nov 13, 2024

Conversation

Natoandro
Copy link
Contributor

  • Remove prisma count operation: it does not work, making it work like on the prisma client would complicate the prisma runtime (until we have output transformations...); Use aggregate instead.
  • Increase the delay before exiting the process on the nodejs typegraph client to give the CLI time to process all the output.
  • Remove quaint logs on the typegate (too verbose).

Migration notes


  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

Copy link
Contributor

@michael-0acf4 michael-0acf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is surprising, if I recall this was just a field like any other that we interfaced with the typegraph. Did it change at some point?

@Natoandro
Copy link
Contributor Author

That is surprising, if I recall this was just a field like any other that we interfaced with the typegraph. Did it change at some point?

It panics here.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.49%. Comparing base (865f2c9) to head (84920b9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/typegate/src/log.ts 0.00% 2 Missing ⚠️
src/typegraph/deno/src/typegraph.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #916   +/-   ##
=======================================
  Coverage   77.49%   77.49%           
=======================================
  Files         149      149           
  Lines       18357    18357           
  Branches     1788     1788           
=======================================
  Hits        14226    14226           
  Misses       4108     4108           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natoandro Natoandro merged commit 87efa1e into main Nov 13, 2024
12 of 14 checks passed
@Natoandro Natoandro deleted the remove-prisma-count branch November 13, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants