Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk)!: unify JS/TS imports #926

Merged
merged 10 commits into from
Nov 28, 2024
Merged

feat(sdk)!: unify JS/TS imports #926

merged 10 commits into from
Nov 28, 2024

Conversation

Natoandro
Copy link
Contributor

@Natoandro Natoandro commented Nov 26, 2024

Solves MET-737:

  • Unify JS/TS imports
  • Add more test for the published packages: test JSR and NPM packages on Nodejs and Deno, with the same typegraph definitions. (on a follow-up PR after the next release)
  • Prepare for version 0.5.0-rc.7

Migration notes

BREAKING CHANGES:

  • TypeScript SDK imports for should be changed on Deno, removing the .ts extension:
    • @typegraph/sdk/index.ts --> @typegraph/sdk
    • @typegraph/sdk/*.ts --> @typegraph/sdk/*

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

Sorry, something went wrong.

Copy link

linear bot commented Nov 26, 2024

@Natoandro Natoandro requested review from Yohe-Am, michael-0acf4, zifeo and luckasRanarison and removed request for Yohe-Am November 26, 2024 21:44
michael-0acf4
michael-0acf4 previously approved these changes Nov 26, 2024
Copy link
Contributor

@michael-0acf4 michael-0acf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah so this is what you meant! This is far better for the playground indeed.

@Natoandro Natoandro force-pushed the met-737-unify-import-maps branch from 814b1bf to 7995047 Compare November 27, 2024 05:11
…h path is none
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.68%. Comparing base (2fbb49a) to head (6a5d41a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #926   +/-   ##
=======================================
  Coverage   77.68%   77.68%           
=======================================
  Files         149      149           
  Lines       18500    18500           
  Branches     1795     1795           
=======================================
  Hits        14372    14372           
  Misses       4105     4105           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natoandro Natoandro merged commit 822437b into main Nov 28, 2024
13 checks passed
@Natoandro Natoandro deleted the met-737-unify-import-maps branch November 28, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants