Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent infinite recursion on visitor2 #940

Closed
wants to merge 1 commit into from

Conversation

Natoandro
Copy link
Contributor

  • Solve MET-781
    • Skip the node when a cycle is detected

Migration notes


  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

Copy link

linear bot commented Dec 16, 2024

@Natoandro
Copy link
Contributor Author

@luckasRanarison I could not reproduce the issue with the local tests for cyclic types here. It would be great if you could setup a small repro ;-p

@luckasRanarison
Copy link
Contributor

@Natoandro Yohe already fixed that issue in his PR so I think you can close this

@Natoandro Natoandro closed this Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.81%. Comparing base (64ed210) to head (319fc4b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #940   +/-   ##
=======================================
  Coverage   77.81%   77.81%           
=======================================
  Files         153      153           
  Lines       18960    18960           
  Branches     1894     1894           
=======================================
  Hits        14754    14754           
  Misses       4182     4182           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants