Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waitscreen while loading #36

Open
wants to merge 109 commits into
base: refactor-traits
Choose a base branch
from
Open

Waitscreen while loading #36

wants to merge 109 commits into from

Conversation

kris10ansn
Copy link

This is my first time doing a pull request, ever 😅

This commit makes the wait screen show up while loading. When the level is done loading the screen stays for however many seconds there are left. If the loading takes more than two seconds it should disappear instantly.

Now there are some caveats:

  • I modified the createPlayerProgressLayer function to rather take player and levelname than the whole level as an argument (the level isn't available before loading).
  • I created a createDummyDashboardLayer for the waitscreen as the createDashboardLayer needs access to the level to get ahold of the leveltimer. This could be done in other ways too, like adding the dashboard after the level is loaded. This would not be as seemless unless you are hosting the game on your own computer with little to no loading time.. There are probably better ways to do this, but i simply didn't have time to explore it.

@pomle
Copy link
Contributor

pomle commented May 5, 2020

Very cool! It looks like this PR is missing your changes. Let me know in the chat if you need help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants