Release/version 0.6.0 #54

Lakorthus · 2023-08-09T15:19:58Z

What

Test/integration setup by @piratejas in Test/integration setup #50
Feat/lint by @Lakorthus in Feat/lint #51
refactor: get bids with sort by @Lakorthus in refactor: get bids with sort #52
Refactor/pagination by @piratejas in Refactor/pagination #53

How to review

make test

Who can review

@nshumoogum

Co-authored-by: Pira Tejasakulsin <[email protected]>

Bids API: Create Hello world endpoint

Co-authored-by: Julio Velezmoro <[email protected]>

Co-authored-by: Pira Tejasakulsin <[email protected]>

Co-authored-by: Julio Velezmoro <[email protected]>

Feat/create new bid

fix: renamed files and folders for readability

fix: changed set_status

Co-authored-by: Julio Velezmoro <[email protected]>

Feat/swagger spec

Co-authored-by: Julio Velezmoro <[email protected]>

Refactor/post bid endpoint

…s; serialised bid_doc using schema

…stom error response

… build/run

Test/integration setup

Feat/lint

… implemented skip and limit on get_questions

…limit and skip

refactor: get bids with sort

…responses for resource lists

Refactor/pagination

Lakorthus and others added 30 commits June 20, 2023 12:53

Create Hello world endpoint

2089170

Co-authored-by: Pira Tejasakulsin <[email protected]>

tested and updated readme instructions for running app

1571f0a

test: test_hello_world controller function.

ea1d499

Co-authored-by: Pira Tejasakulsin <[email protected]>

test: routes on hello_world

0af031b

Merge pull request #2 from methods/feat_hello_world

b0d5802

Bids API: Create Hello world endpoint

feat: added and manually tested post route for bid

63c02ba

Co-authored-by: Julio Velezmoro <[email protected]>

feat: saving data in memory and separating logic

ac87d4e

Co-authored-by: Pira Tejasakulsin <[email protected]>

wip: add phase info to success/failed

d1f230c

Co-authored-by: Julio Velezmoro <[email protected]>

feat: field validation, set status enum

53d3913

Co-authored-by: Julio Velezmoro <[email protected]>

test: add post bid route tests

3d0dc1c

Merge pull request #3 from methods/feat/create-new-bid

7641b4b

Feat/create new bid

fix: renamed files and folders for readability

2d6d8cf

Merge pull request #4 from methods/fix/filenames-improvement

65901b1

fix: renamed files and folders for readability

fix: changed set_status

027cc43

wip: swagger spec config

817cd3d

docs: Update contribution guidelines to incl. release and tagging

cc3763c

fix: installed flask_swagger_ui; created swagger_config.yml

34c1a45

chore: flask-ui added to the requirements

44145f6

Merge branch 'feat/swagger-spec' into fix/set-status-enum

4a35b21

Merge pull request #7 from methods/fix/set-status-enum

03520b5

fix: changed set_status

fix: swagger config structure

2d2d28f

refactor: swagger config components and refs

5f10e67

Co-authored-by: Julio Velezmoro <[email protected]>

feat: completed swagger spec for post bid endpoint

cd2bc74

Merge pull request #8 from methods/feat/swagger-spec

0e0677e

Feat/swagger spec

refactor: success and failed phase info

9249e09

Co-authored-by: Julio Velezmoro <[email protected]>

refactor: added helper function and logic for feedback

6d1fdbc

Merge pull request #9 from methods/refactor/post-bid-endpoint

3ac5bd2

Refactor/post bid endpoint

refactor: added marshmallow schemas; renamed classes and fixed import…

8d7aaac

…s; serialised bid_doc using schema

refactor: handling ValidationError with marshmallow and outputting cu…

1b48bc2

…stom error response

refactor: added test request bodies to check validation

ed395ce

piratejas and others added 29 commits August 4, 2023 13:27

refactor: added dbclean target to root makefile

c4c8648

docs: updated readme

5d930ed

docs: removed repeated steps in readme

bda4a13

docs: removed unnecessary steps to install pre-requisites

f4e6bd8

fix: flake8 compliance

23dced3

docs: reordered steps as some make targets will be unavailable before…

9c701f5

… build/run

test: added skip marker to integration test in progress

4d109db

fix: C0103: doesn't conform to snake_case naming style (invalid-name)

75161f0

fix: C0114: Missing module docstring (missing-module-docstring)

926ba45

fix: C0411: Wrong import order %s

23cabcc

Merge pull request #50 from methods/test/integration-setup

a0ae485

Test/integration setup

Merge branch 'develop' into feat/lint

1994871

fix: merge conflicts

7246de6

Merge pull request #51 from methods/feat/lint

38c1a22

Feat/lint

feat: updated swagger; created pagination validation helper function;…

141a213

… implemented skip and limit on get_questions

test: tested validate_pagination; wip - mocking chained db call with …

a4ad121

…limit and skip

refactor: get bids with sort

30c8be1

test: debugged get tests

ee7dfdf

refactor: modified script and test_data for larger dataset

aa8eb39

refactor: refactor and renamed validate_questions_sort

ac2fcf4

test: added tests for invalid pagination

e54bb37

test: added reused test variables to configtest file as fixtures

63e6871

docs: updated swagger for sort param

53c830b

refactor: modified validate_sort helper to allow reuse

04f96c6

test: bid test with pagination and sort

4729223

Merge pull request #52 from methods/feat/bids-pag-sort

9308192

refactor: get bids with sort

feat: added create and drop indexes commands to updated swagger with …

d73b11b

…responses for resource lists

test: added endpoint tests for get

b26174a

Merge pull request #53 from methods/refactor/pagination

b7fee87

Refactor/pagination

Lakorthus requested a review from nshumoogum August 9, 2023 15:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release/version 0.6.0 #54

Release/version 0.6.0 #54

Lakorthus commented Aug 9, 2023

Release/version 0.6.0 #54

Are you sure you want to change the base?

Release/version 0.6.0 #54

Conversation

Lakorthus commented Aug 9, 2023

What

How to review

Who can review