Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup optional arguments in api #13

Merged
merged 6 commits into from
May 28, 2024
Merged

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented May 28, 2024

  • Adds optional kwargs in function definitions so that functions are more self-documenting.
  • Allows writing json string directly.
  • Adds tests which test a full read-write cycle in a fresh temporary database (ie. whether the expected data is read back).

@thorbjoernl thorbjoernl force-pushed the better-optional-args-handling branch from 8008d42 to 0ab5cc1 Compare May 28, 2024 08:10
@thorbjoernl thorbjoernl force-pushed the better-optional-args-handling branch from 0ab5cc1 to 8bbd8d4 Compare May 28, 2024 11:37
@thorbjoernl thorbjoernl marked this pull request as ready for review May 28, 2024 12:14
@thorbjoernl thorbjoernl merged commit f54b4e0 into main May 28, 2024
1 check passed
@thorbjoernl thorbjoernl deleted the better-optional-args-handling branch May 28, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant