-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sqlitedb API implementation #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations, having two independent implementations is an important step for aerovaldb.
With this step you also refactored much of jsondb code and testing, which was expected, but is also a bit overwhelming when reading the PR. I would have prefered several smaller PRs, e.g. about the refactoring of jsondb, changes introduced in testing and then only sqlitedb. Now, it is impossilbe to see for me where a change is coming from and where it might eventually break functionality. But this just as a note for the future.
What is completely missing is the documention on 'How to implement add an additional aerovaldb implementation', similar to https://pyaro.readthedocs.io/en/latest/how-to-add-new-reader.html . With the addition of sqlitedb you made a lot of decisions about that, and that should be documented. Since the documentation isn't strictly necessary for this PR, I approve.
Thanks for reviewing :) I'll try to keep changes smaller and more manageable in the future. I've created an issue for the documentation here for future reference: #80 |
Change Summary
Provides an initial implementation for storing json blobs in an sqlite database.
Related issue number
closes Sqlite API #16,
closes AerovalDB should support more than one db-format #52
Checklist