Changes to Enable SSH for Repository hosting #4
Conversation
We use Git over SSH for repository hosting. Adding the ability for this cookbook to be used for configuring the phab host for this. Runs an additional SSH Daemon on port 617 (configurable) for this purpose. Test cases added to ensure the daemon is installed and configured. N.B. This is only for Ubuntu 14.04 or newer, due to need for AuthorizedKeysCommand which came in OpenSSH 6.2. Functionality is disabled on Ubuntu 12.04, and test cases are skipped in that case.
| default['phabricator']['ssh_vcs_port'] = '617' | ||
|
|
||
| # User for Source code hosting | ||
| default['phabricator']['vcsuser'] = 'git' |
There was a problem hiding this comment.
I suggest that the VCS functions are namespaced into e.g. ['phabricator']['vcs_hosting'] (or, preferably, something a little more elegant)
There was a problem hiding this comment.
Good idea, thanks
|
Thank you very much for the patch. I'll look a bit further into it, possibly tomorrow, or at least when I have free time 👍 |
|
Sorry for spamming with comments. Can you run your patch through Foodcritic to eliminate all linting errors? (with the exception that spaces should be set to 4, not 2) |
|
Sure thing.. although I noted you're also using double quotes throughout the cookbook not single.. and are using the old style ruby hash syntax. Would you like those fixed up, or would it be ok to commit a .rubocop.yml to set these preferences? |
|
Ah, don't worry about those. I should fix these in a separate commit, thanks. |
Making naming more consistent and breaking out the vcs hosting over ssh into a separate attribute namespace under `node['phabricator']['vcs_ssh']` Fixing some linter errors too, and deleting an unused template.
|
I pushed changes to this last week - are you happy with them? or would you like further change? |
|
Sorry, been very busy at work so haven't gotten any time to look at it. I'll check it out tomorrow. |
| append_paths << '/usr/local/bin' | ||
| append_paths << '/usr/lib/git-core' | ||
|
|
||
| default['phabricator']['config']['environment.append-paths'] = %('#{append_paths}') |
There was a problem hiding this comment.
I'm curious to why this attribute is conofigured in vcs_ssh_hosting.rb and not default.rb? It looks like it belongs in the latter file.
We use Git over SSH for repository hosting. Adding the ability for
this cookbook to be used for configuring the phab host for this.
Runs an additional SSH Daemon on port 617 (configurable) for this
purpose.
Test cases added to ensure the daemon is installed and configured.
N.B. This is only for Ubuntu 14.04 or newer, due to need for
AuthorizedKeysCommand which came in OpenSSH 6.2.
Functionality is disabled on Ubuntu 12.04, and test cases are skipped
in that case.