Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try fix CollectorRegistry issue #256

Merged
merged 4 commits into from
Feb 7, 2025
Merged

try fix CollectorRegistry issue #256

merged 4 commits into from
Feb 7, 2025

Conversation

charlienegri
Copy link
Contributor

@charlienegri charlienegri commented Feb 6, 2025

Summary: trying to address ValueError: Duplicated timeseries in CollectorRegistry

Related issue: #255

Suggested reviewer(s):

Reviewer checklist:

  • The headers of all files contain a reference to the repository license
  • 100% test coverage of new code - meaning:
    • The overall test coverage increased or remained the same as before
    • Every function is accompanied with a test suite
    • Tests are both positive (testing that the function work as intended with valid data) and negative (testing that the function behaves as expected with invalid data, e.g., that correct exceptions are thrown)
    • Functions with optional arguments have separate tests for all options
  • Examples are supported by doctests
  • All tests are passing
  • All names (e.g., files, classes, functions, variables) are explicit
  • Documentation (as docstrings) is complete and understandable

The checklist is based on the S-ENDA conventions and definition of done (see General Conventions). The above points are not necessarily relevant to all contributions. In that case, please add a short explanation to help the reviewer.

@charlienegri charlienegri requested a review from magnarem February 6, 2025 15:02
@charlienegri
Copy link
Contributor Author

tested locally but not sure at all if it fixes the issue

@mortenwh
Copy link
Collaborator

mortenwh commented Feb 7, 2025

Thanks!

@mortenwh mortenwh merged commit 2ea6bbc into main Feb 7, 2025
5 checks passed
@mortenwh mortenwh deleted the flask_exporter_fix_255 branch February 7, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants