Skip to content

Commit

Permalink
comment why MDA8 output is specical case
Browse files Browse the repository at this point in the history
  • Loading branch information
lewisblake committed Jul 9, 2024
1 parent 6be91d4 commit 2dad9c7
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion pyaerocom/aeroval/experiment_output.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from pyaerocom.aeroval.setupclasses import EvalSetup
from pyaerocom.aeroval.varinfo_web import VarinfoWeb
from pyaerocom.exceptions import EntryNotAvailable, VariableDefinitionError
from pyaerocom.stats.mda8.const import MDA8_OUTPUT_VARS
from pyaerocom.stats.mda8.const import MDA8_INPUT_VARS, MDA8_OUTPUT_VARS
from pyaerocom.stats.stats import _init_stats_dummy
from pyaerocom.variable_helpers import get_aliases

Expand Down Expand Up @@ -699,8 +699,12 @@ def _is_part_of_experiment(self, obs_name, obs_var, mod_name, mod_var) -> bool:
True if this combination is valid, else False.
"""

# MDA8 is computed on-the-fly ONLY if a MDA8_INPUT_VAR at hourly freq is detected.
# Consequently, it is not specified in a config but should be included as part of the experiment.
if obs_var in MDA8_OUTPUT_VARS and mod_var in MDA8_OUTPUT_VARS:
return True

Check warning on line 706 in pyaerocom/aeroval/experiment_output.py

View check run for this annotation

Codecov / codecov/patch

pyaerocom/aeroval/experiment_output.py#L706

Added line #L706 was not covered by tests

# get model entry for model name
try:
mcfg = self.cfg.model_cfg.get_entry(mod_name)
Expand Down

0 comments on commit 2dad9c7

Please sign in to comment.