Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue with loffset #1305

Merged
merged 1 commit into from
Aug 14, 2024
Merged

fix: Issue with loffset #1305

merged 1 commit into from
Aug 14, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Aug 13, 2024

Change Summary

Fix the issue found by @heikoklein where loffset wasn't working properly after xarray 2024.7 changes

Related issue number

NA / Chat

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added the bug 🐛 Something isn't working label Aug 13, 2024
@thorbjoernl thorbjoernl added this to the m2024-08 milestone Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.00%. Comparing base (db560b4) to head (8355b4a).
Report is 4 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1305   +/-   ##
=========================================
  Coverage     78.99%   79.00%           
=========================================
  Files           136      136           
  Lines         20795    20797    +2     
=========================================
+ Hits          16428    16430    +2     
  Misses         4367     4367           
Flag Coverage Δ
unittests 79.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl marked this pull request as ready for review August 13, 2024 13:30
@heikoklein
Copy link
Member

Thanks, I have pulled this branch and I'm re-running reporting-2024. This will take a couple of hours.

@heikoklein heikoklein merged commit 65bf368 into main-dev Aug 14, 2024
8 checks passed
@heikoklein
Copy link
Member

reporting-2024 worked nicely, with much smaller log-files due to deprecations. Thanks

@heikoklein heikoklein deleted the fix-off-by-one-error branch August 14, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants