Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EARLINET cloud filtering #1315

Merged
merged 5 commits into from
Aug 20, 2024
Merged

EARLINET cloud filtering #1315

merged 5 commits into from
Aug 20, 2024

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Aug 19, 2024

Change Summary

Implement the different types of cloud filtering provided by different EARLINET stations.

Related issue number

Close #1310

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@lewisblake lewisblake added this to the m2024-09 milestone Aug 19, 2024
@lewisblake lewisblake added obs-update Update related to existing observation dataset CAMS2_82 Issues related to the CAMS2_82 contract labels Aug 19, 2024
@lewisblake
Copy link
Member Author

Blocked by #1311

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 40.74074% with 16 lines in your changes missing coverage. Please review.

Project coverage is 78.97%. Comparing base (89b9921) to head (9e48af9).
Report is 11 commits behind head on main-dev.

Files Patch % Lines
pyaerocom/aeroval/experiment_output.py 9.09% 10 Missing ⚠️
pyaerocom/aeroval/coldatatojson_engine.py 0.00% 3 Missing ⚠️
pyaerocom/aeroval/coldatatojson_helpers.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1315      +/-   ##
============================================
- Coverage     79.00%   78.97%   -0.03%     
============================================
  Files           136      136              
  Lines         20797    20812      +15     
============================================
+ Hits          16430    16436       +6     
- Misses         4367     4376       +9     
Flag Coverage Δ
unittests 78.97% <40.74%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake lewisblake marked this pull request as ready for review August 20, 2024 12:37
Copy link
Member

@jgriesfeller jgriesfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but CI has not finished yet. Merge when CI has passed

@lewisblake lewisblake merged commit 7c6d8b8 into main-dev Aug 20, 2024
6 of 8 checks passed
@lewisblake lewisblake deleted the cloud_filtering_1310 branch August 20, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CAMS2_82 Issues related to the CAMS2_82 contract obs-update Update related to existing observation dataset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement cloud filtering on EARLINET reader
3 participants