Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude mda8 from maps #1325

Merged
merged 2 commits into from
Aug 27, 2024
Merged

exclude mda8 from maps #1325

merged 2 commits into from
Aug 27, 2024

Conversation

charlienegri
Copy link
Collaborator

@charlienegri charlienegri commented Aug 27, 2024

since they are computed pre-colocation and the variable does not belong there at the moment

Related issue number

solves #1324

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

… variable does not belong there at the moment
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.96%. Comparing base (9e48af9) to head (5dfa5f2).
Report is 10 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1325      +/-   ##
============================================
- Coverage     78.97%   78.96%   -0.01%     
============================================
  Files           136      136              
  Lines         20812    20813       +1     
============================================
  Hits          16436    16436              
- Misses         4376     4377       +1     
Flag Coverage Δ
unittests 78.96% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charlienegri charlienegri marked this pull request as ready for review August 27, 2024 07:28
@charlienegri
Copy link
Collaborator Author

I am testing it with a weekly experiment

Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thorbjoernl thorbjoernl merged commit e1eab75 into main-dev Aug 27, 2024
8 checks passed
@thorbjoernl thorbjoernl deleted the eclude_conco3mda8_frommaps branch August 27, 2024 08:27
@thorbjoernl thorbjoernl added this to the m2024-09 milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants