Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pm1 non refractory #1337

Merged
merged 8 commits into from
Sep 11, 2024
Merged

Pm1 non refractory #1337

merged 8 commits into from
Sep 11, 2024

Conversation

heikoklein
Copy link
Member

@heikoklein heikoklein commented Sep 11, 2024

Change Summary

adding pm1_non_refractory matrix to ebas and emep evaluation after new ebas extract.

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@heikoklein heikoklein added this to the m2024-09 milestone Sep 11, 2024
@heikoklein heikoklein marked this pull request as ready for review September 11, 2024 12:11
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.97%. Comparing base (80a44e1) to head (2ae1c47).
Report is 23 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1337   +/-   ##
=========================================
  Coverage     78.97%   78.97%           
=========================================
  Files           136      136           
  Lines         20815    20815           
=========================================
  Hits          16438    16438           
  Misses         4377     4377           
Flag Coverage Δ
unittests 78.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but check comment.

pyaerocom/data/variables.ini Show resolved Hide resolved
@heikoklein heikoklein merged commit b222cfc into main-dev Sep 11, 2024
8 checks passed
@heikoklein heikoklein deleted the pm1_non_refractory branch September 11, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants