Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pickle file from CI used in test_collocation_3d #925

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Conversation

lewisblake
Copy link
Member

Close #914

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (749811b) 79.71% compared to head (856646f) 79.73%.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev     #925      +/-   ##
============================================
+ Coverage     79.71%   79.73%   +0.01%     
============================================
  Files           103      103              
  Lines         17736    17736              
============================================
+ Hits          14139    14141       +2     
+ Misses         3597     3595       -2     
Flag Coverage Δ
unittests 79.73% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pyaerocom/aeroval/modelentry.py 84.00% <100.00%> (ø)
pyaerocom/colocateddata.py 79.56% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@avaldebe avaldebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the now unused import pickle and TEST_DATA["Earlinet-test-3d-collocation"]

tests/test_colocation_3d.py Show resolved Hide resolved
Copy link
Collaborator

@avaldebe avaldebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🎆

@avaldebe
Copy link
Collaborator

looks like CI is failing because you need to run isort on the files you changed

Copy link
Collaborator

@avaldebe avaldebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🎆

@lewisblake lewisblake marked this pull request as ready for review October 16, 2023 09:48
@lewisblake lewisblake merged commit ee4087c into main-dev Oct 16, 2023
17 of 19 checks passed
@lewisblake lewisblake deleted the fix914 branch February 23, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pickle file in CI for Earlinet testing
2 participants