Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some more CAMS2-40 task4041 work #944

Merged

Conversation

jgriesfeller
Copy link
Member

adding some sea salt variables and and nh4

@jgriesfeller jgriesfeller self-assigned this Nov 9, 2023
@jgriesfeller jgriesfeller linked an issue Nov 9, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8950147) 77.65% compared to head (2118b98) 78.95%.

Files Patch % Lines
pyaerocom/aeroval/modelmaps_engine.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev     #944      +/-   ##
============================================
+ Coverage     77.65%   78.95%   +1.29%     
============================================
  Files           105      105              
  Lines         18423    18423              
============================================
+ Hits          14306    14545     +239     
+ Misses         4117     3878     -239     
Flag Coverage Δ
unittests 78.95% <75.00%> (+1.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor clean up. I assume the non-linear color scales are intentional

pyaerocom/aeroval/glob_defaults.py Show resolved Hide resolved
pyaerocom/data/variables.ini Show resolved Hide resolved
pyaerocom/data/variables.ini Outdated Show resolved Hide resolved
pyaerocom/data/variables.ini Show resolved Hide resolved
…thub.com:metno/pyaerocom into griesie-943-add-removed-conversion-factors-again
@jgriesfeller jgriesfeller merged commit 163d3f9 into main-dev Dec 4, 2023
20 of 21 checks passed
@jgriesfeller jgriesfeller deleted the griesie-943-add-removed-conversion-factors-again branch December 4, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some more cams2-40 / task4041 adjustments
2 participants