Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3S2 work #962

Closed
wants to merge 17 commits into from
Closed

Conversation

jgriesfeller
Copy link
Member

Not all of this PR will be merged since it's project specific (e.g. color bars)

@jgriesfeller jgriesfeller linked an issue Jan 12, 2024 that may be closed by this pull request
@jgriesfeller jgriesfeller self-assigned this Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.95%. Comparing base (dd96aad) to head (2397119).
Report is 29 commits behind head on main-dev.

❗ Current head 2397119 differs from pull request most recent head 7f393f7. Consider uploading reports for the commit 7f393f7 to get more accurate results

Files Patch % Lines
pyaerocom/io/readaeronetbase.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev     #962      +/-   ##
============================================
- Coverage     79.84%   78.95%   -0.90%     
============================================
  Files           108      105       -3     
  Lines         18843    18429     -414     
============================================
- Hits          15045    14550     -495     
- Misses         3798     3879      +81     
Flag Coverage Δ
unittests 78.95% <66.66%> (-0.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgriesfeller
Copy link
Member Author

The generally usefull parts have been merged already in #1104. deleteing this PR therefore. The C3S2 specific changes have been kept here: https://github.com/jgriesfeller/pyaerocom_c3s/blob/956-griesie-recent-c3s2-developments/pyaerocom/aeroval/glob_defaults.py (as refernce for future work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

recent C3S2 developments
2 participants