Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Flaky test rose-task-run/44 #2750

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Fix Flaky test rose-task-run/44 #2750

merged 2 commits into from
Jan 19, 2024

Conversation

wxtim
Copy link
Contributor

@wxtim wxtim commented Dec 14, 2023

I think that the second task (which is supposed to keep the workflow in a running state) was finishing too quickly on CI and the workflow was shutting down prematurely.

@wxtim wxtim changed the base branch from master to 2.1.x December 14, 2023 14:19
@wxtim wxtim self-assigned this Dec 14, 2023
@wxtim wxtim force-pushed the fix.flaky_bunch_test branch from 4371b2f to 7d7ab85 Compare December 14, 2023 14:22
@wxtim wxtim added the bug label Dec 14, 2023
@wxtim wxtim added this to the 2.1.1 milestone Dec 14, 2023
@MetRonnie
Copy link
Contributor

The long task currently sleeps for 5 mins but the test only runs for just over 1 min. Looks like the failure is due to a polling grep timing out after 1 min.
https://github.com/metomi/rose/actions/runs/7204565601/job/19626203834#step:14:37

@MetRonnie
Copy link
Contributor

Unfortunately it wipes evidence of the failure at this line:

rose/t/rose-task-run/44-bunch-incremental.t

Line 108 in 7d7ab85

run_pass "cleanup" cylc clean -y "${FLOW}"

@MetRonnie MetRonnie marked this pull request as draft December 14, 2023 16:01
@wxtim wxtim mentioned this pull request Jan 2, 2024
Merged
@wxtim wxtim force-pushed the fix.flaky_bunch_test branch from 6c7f730 to e173b29 Compare January 3, 2024 15:10
@wxtim wxtim marked this pull request as ready for review January 3, 2024 15:19
@MetRonnie
Copy link
Contributor

Still waiting for above comment to be addressed

@wxtim
Copy link
Contributor Author

wxtim commented Jan 18, 2024

Still waiting for above comment to be addressed

Which one?

@MetRonnie
Copy link
Contributor

MetRonnie commented Jan 18, 2024 •
edited
Loading

Unfortunately it wipes evidence of the failure at this line:

rose/t/rose-task-run/44-bunch-incremental.t

Line 108 in 7d7ab85

run_pass "cleanup" cylc clean -y "${FLOW}"

If this breaks again it's difficult to diagnose if the evidence is deleted

@wxtim
Copy link
Contributor Author

wxtim commented Jan 19, 2024

Unfortunately it wipes evidence of the failure at this line:

rose/t/rose-task-run/44-bunch-incremental.t

Line 108 in 7d7ab85

run_pass "cleanup" cylc clean -y "${FLOW}"

If this breaks again it's difficult to diagnose if the evidence is deleted

Latest commit should fix.

@MetRonnie MetRonnie merged commit 8aa17de into metomi:2.1.x Jan 19, 2024
4 of 5 checks passed
@MetRonnie MetRonnie added small and removed bug labels Jan 19, 2024
@MetRonnie MetRonnie linked an issue May 23, 2024 that may be closed by this pull request
flaky test: t/rose-task-run/44-bunch-incremental.t #2719
Closed
@MetRonnie MetRonnie modified the milestones: 2.1.1, 2.3.0 May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

@markgrahamdawson markgrahamdawson Awaiting requested review from markgrahamdawson

Assignees

@wxtim wxtim

Labels
small
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

flaky test: t/rose-task-run/44-bunch-incremental.t
2 participants
@wxtim @MetRonnie