Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix.orphan #2838

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fix.orphan #2838

merged 1 commit into from
Nov 28, 2024

Conversation

wxtim
Copy link
Contributor

@wxtim wxtim commented Nov 28, 2024

  • Avoid displaying :orphan: directive in built pages.
  • Remove unecessary includes for hyperlinks.rst.

Built copy at: https://wwwspice/~tim.pillinger/doc/rose/rose%202.4.0.dev/html/tutorial/rose/configurations.html

Background

According to this thread on readthedocs this is a problem with including RST metadata.

@wxtim wxtim requested a review from oliver-sanders November 28, 2024 08:57
@wxtim wxtim self-assigned this Nov 28, 2024
@wxtim wxtim added this to the 2.3.x milestone Nov 28, 2024
@oliver-sanders
Copy link
Member

cylc-doc avoids the need for this entirely by giving the include file a non-rst extension: https://github.com/cylc/cylc-doc/blob/master/src/hyperlinks.rst.include

@wxtim
Copy link
Contributor Author

wxtim commented Nov 28, 2024

@oliver-sanders fixed

@oliver-sanders
Copy link
Member

Base branch does not match milestone.

@wxtim wxtim changed the base branch from master to 2.3.x November 28, 2024 14:41
remove surplus to requirements includes.

better solution
@wxtim wxtim merged commit d617e60 into metomi:2.3.x Nov 28, 2024
1 check passed
@wxtim wxtim deleted the fix.orphan branch November 28, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants