-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release: 2.4.0 #2844
Prepare release: 2.4.0 #2844
Conversation
Workflow: Release stage 1 - create release PR (Rose 2+ only), run: 22
Tests failing on master - will try and at least fix the linting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog needs fixing.
@oliver-sanders One approval enough? Just waiting for the tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved in principle, but why are we making a release actually, if there are no changes? Why not put cylc-rose back to metomi-rose 2.3 and just release cylc-rose?
metomi-rose release isn't strictly necessary, it's just our process to synchronize minor releases (cylc/cylc-admin#199). This ensures compatibility breaks don't sneak in by accident. There will usually be some minor changes to keep Rose in sync with Cylc, there are actually two tutorial workflow updates on this branch so it's not completely unchanged. |
✔️
|
⚡ Merging this PR will automatically create a GitHub Release & publish the package ⚡
This PR was created by the
Release stage 1 - create release PR (Rose 2+ only)
workflow, triggered by @wxtimTests:
master
:Checklist:
0
other open issues/PRs on milestone 2.4.0 at time of PR creationNext steps:
Important
Do not use
[skip ci]
in commit messages pushed to this PR, as it will prevent the 2nd stage release workflow from running.