Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release: 2.4.0 #2844

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Prepare release: 2.4.0 #2844

merged 4 commits into from
Jan 9, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 8, 2025

⚡ Merging this PR will automatically create a GitHub Release & publish the package ⚡

This PR was created by the Release stage 1 - create release PR (Rose 2+ only) workflow, triggered by @wxtim

Tests:

  • Tests last run on master:
    test.yml
  • ✔️ Build check passed - see the workflow run (number 22) for more info

Checklist:

  • Milestone complete?
    0 other open issues/PRs on milestone 2.4.0 at time of PR creation

Next steps:

  • @wxtim should request 1 or 2 reviews
  • If any further changes are needed, push to this PR branch
  • After merging, the bot will comment below with a link to the release (if not, look at the PR checks tab)

Important

Do not use [skip ci] in commit messages pushed to this PR, as it will prevent the 2nd stage release workflow from running.

Workflow: Release stage 1 - create release PR (Rose 2+ only), run: 22
@github-actions github-actions bot added this to the 2.4.0 milestone Jan 8, 2025
@github-actions github-actions bot added the release Warning: for release PRs only. Merging this PR will trigger GH Actions to publish. label Jan 8, 2025
@wxtim
Copy link
Contributor

wxtim commented Jan 8, 2025

Tests failing on master - will try and at least fix the linting

Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog needs fixing.

CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@wxtim wxtim requested a review from oliver-sanders January 8, 2025 16:27
@wxtim
Copy link
Contributor

wxtim commented Jan 8, 2025

@oliver-sanders One approval enough? Just waiting for the tests?

Copy link
Contributor

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in principle, but why are we making a release actually, if there are no changes? Why not put cylc-rose back to metomi-rose 2.3 and just release cylc-rose?

@oliver-sanders
Copy link
Member

oliver-sanders commented Jan 9, 2025

metomi-rose release isn't strictly necessary, it's just our process to synchronize minor releases (cylc/cylc-admin#199). This ensures compatibility breaks don't sneak in by accident.

There will usually be some minor changes to keep Rose in sync with Cylc, there are actually two tutorial workflow updates on this branch so it's not completely unchanged.

@wxtim wxtim merged commit dae6e3d into master Jan 9, 2025
5 of 6 checks passed
@wxtim wxtim deleted the prepare-2.4.0 branch January 9, 2025 10:16
Copy link
Contributor Author

github-actions bot commented Jan 9, 2025

✔️ success

Next steps for @wxtim:


Comment created by workflow: Release stage 2 - auto publish, run: 41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Warning: for release PRs only. Merging this PR will trigger GH Actions to publish.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants