Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Problem:
In the Quickstart of the README, you reference other schema with the
#'<SCHEMA>
syntax. But it doesn't work, it gives:malli.core/invalid-schema
error.Steps to reproduce:
deps.edn
filemalli.generator
or validating a handcrafted User object, it always gives the following error :; :malli.core/invalid-schema {:schema #'user/UserId}
How to fix:
Just remove the
#'
from schema references. Note that I still get another error:malli.core/invalid-ref {:ref [:map [:id :string] [:address [:map [:street :string] [:country [:enum "FI" "UA"]]]] [:friends [:set #:gen{:max 2} [:ref #'user/User]]]]}
. It maybe because I don't know how to use:ref
. But in my real world app removing#'
totally fixed the problem.Further suggestion (if I may) :
The Quickstart is the only place I found where you compose a schema out of smaller schema and demonstrate composition through schema reuse. Is it because it's limited? I think it deserves at least a formal documentation like : "You can create a schema with any Schema syntax and just reuse it to compose bigger schema and avoid code duplication` or something like that. You get the point I hope.
Thanks!