Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place the openapi deprecation tag directly under parameters #714

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mokshasoft
Copy link

When creating an openapi handler via reitit.openapi/create-openapi-handler the parameter deprecation tags are put under the schema tag, not directly under the parameters tag.

https://swagger.io/docs/specification/v3_0/describing-parameters/#deprecated-parameters

The openapi.json generated without this fix:

          {
            "in": "query",
            "name": "include-legacy-information",
            "required": false,
            "schema": {
              "deprecated": true
            },
          },

The openapi.json generated with this fix:

          {
            "in": "query",
            "name": "include-legacy-information",
            "required": false,
            "schema": {},
            "deprecated": true
          },

I was able to run these tests, that passed:
./scripts/test.sh clj
but not these, that failed for an unrelated reason:
./scripts/test.sh cljs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant