Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/series request optimizations #559

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

akvlad
Copy link
Collaborator

@akvlad akvlad commented Aug 30, 2024

use pako for gzip; ADVANCED_SERIES_REQUEST_LIMIT to limit /series response

@metrico metrico deleted a comment from github-actions bot Aug 30, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 1.64 MB vitaly

View full report↗︎

Copy link

Workflow Telemetry - K6 Test qxip/qryn / Run k6 on qryn:latest

Workflow telemetry for commit 77949256f7bf18c26a6177af010e583c3d8a25da
You can access workflow job details here

Step Trace

gantt
	title Run k6 on qryn:latest
	dateFormat x
	axisFormat %H:%M:%S
	Set up job : milestone, 1725041047000, 1725041049000
	Initialize containers : 1725041049000, 1725041067000
	Checkout : 1725041067000, 1725041068000
	Run actions/setup-go@v4 : 1725041068000, 1725041069000
	Download k6 for Prometheus : 1725041069000, 1725041071000
	Download k6 for Prometheus : 1725041071000, 1725041073000
	Collect Workflow Telemetry : 1725041073000, 1725041073000
	Wait for Loki API : 1725041073000, 1725041073000
	Run k6 loki test : 1725041073000, 1725041138000
	Run mv summary.txt loki_summary.txt : 1725041138000, 1725041138000
	Wait for Prom API : 1725041138000, 1725041138000
	Run k6 prometheus test : 1725041138000, 1725041201000
	Run mv summary.txt prom_summary.txt : 1725041201000, 1725041201000
	Wait for Tempo API : 1725041201000, 1725041201000
	Run k6 tempo test : 1725041201000, 1725041271000
	Run mv summary.txt tempo_summary.txt : 1725041271000, 1725041271000
	Strip Text report : 1725041271000, 1725041271000
	Run actions/upload-artifact@v3 : 1725041271000, 1725041272000
	Summary Report : 1725041272000, 1725041272000

Loading

CPU Metrics

chart_stacked_area_time_458f3a6f-ef11-4796-afda-5bf8fccb512d

Memory Metrics

chart_stacked_area_time_a68e276a-275a-4fda-81c8-eb50e626f825

IO Metrics

Read Write
Network I/O chart_line_time_e31fd0ae-bb5f-4394-b0fb-0262e4bc58d2 chart_line_time_f72a0f6d-ea5e-434b-a436-8584d7abd119
Disk I/O chart_line_time_efe70d56-15d0-4c04-b2a5-b1c745ff782e chart_line_time_73e17bb1-0628-4413-af74-235420904e30

Process Trace

Top 100 processes with highest duration

gantt
	title Run k6 on qryn:latest
	dateFormat x
	axisFormat %H:%M:%S

Loading

@akvlad akvlad merged commit d8e30af into master Aug 30, 2024
12 checks passed
@akvlad akvlad deleted the feature/grafana_profiles_plugin branch August 30, 2024 18:08
@humphd
Copy link

humphd commented Sep 2, 2024

@akvlad we started seeing crashes when we updated to this change (v3.2.30) in our cluster:

/app/node_modules/stream-shift/index.js:16
    return state.buffer[0].length
                           ^

TypeError: Cannot read properties of null (reading 'length')
    at getStateLength (/app/node_modules/stream-shift/index.js:16:28)
    at shift (/app/node_modules/stream-shift/index.js:6:99)
    at Duplexify._forward (/app/node_modules/peek-stream/node_modules/duplexify/index.js:168:35)
    at Duplex.onreadable (/app/node_modules/peek-stream/node_modules/duplexify/index.js:134:10)
    at Duplex.emit (node:events:519:28)
    at emitReadable_ (node:internal/streams/readable:832:12)
    at onEofChunk (node:internal/streams/readable:810:5)
    at readableAddChunkPushByteMode (node:internal/streams/readable:464:5)
    at Readable.push (node:internal/streams/readable:390:5)
    at deflator.onEnd (/app/qryn_node.js:142:19)

Not sure if it's our bug (missing some new config) or something for you to know about.

@akvlad
Copy link
Collaborator Author

akvlad commented Sep 2, 2024

@humphd thanks for the report. Will fix.

@akvlad
Copy link
Collaborator Author

akvlad commented Sep 2, 2024

@humphd apparently a node version problem. Very strange. please try 3.2.31.

Sorry for the inconvenience.

@humphd
Copy link

humphd commented Sep 2, 2024

@humphd apparently a node version problem. Very strange. please try 3.2.31.

Sorry for the inconvenience.

Amazing, thank you! We'll try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants