1040 Adjust health checks for ECS #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leite08
force-pushed
the
1040-resize-db-and-ecs_2
branch
from
7055bfa to
0be6e01
Compare
Ref. metriport/metriport-internal#1040 Signed-off-by: Rafael Leite <[email protected]>
leite08
force-pushed
the
1040-resize-db-and-ecs_2
branch
from
0be6e01 to
b4cd733
Compare
Ref. metriport/metriport-internal#1040 Signed-off-by: Rafael Leite <[email protected]>
leite08
commented
Jul 30, 2024
Comment on lines
67
to
+68
| cpu: 1 * vCPU, | ||
| memoryLimitMiB: 1024, | ||
| memoryLimitMiB: 2048, |
There was a problem hiding this comment.
1 vCPU requires at least 2GB of RAM - https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html#task_size
leite08
commented
Jul 30, 2024
Comment on lines
+77
to
+78
| cpu: 1 * vCPU, | ||
| memoryLimitMiB: 2048, |
There was a problem hiding this comment.
0.5 vCPU was not being enough to start the service - health checks were failing, even adjusting those thresholds - context
leite08
commented
Jul 30, 2024
Comment on lines
+294
to
+296
| unhealthyThresholdCount: 4, | ||
| interval: Duration.seconds(20), | ||
| timeout: Duration.seconds(15), |
There was a problem hiding this comment.
leite08
commented
Jul 30, 2024
Comment on lines
+56
to
+57
| cpu: 4 * vCPU, | ||
| memoryLimitMiB: 8192, |
There was a problem hiding this comment.
Actually, considering the original comment and the weekly load of max CPU, taking a closer look at some of the spikes, we see they run for ~100% for minutes, so its clear the CPU is also a bottleneck - see below:
Jul 27:
Jul 26
Jul 29 (single spike)
leite08
requested review from
Goncharo,
Orta21,
RamilGaripov,
jonahkaye and
thomasyopes
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. metriport/metriport-internal#1040
Dependencies
Description
Adjust health checks for ECS - context on each change.
Release Plan