fix: link and unit fix

metrotranscom · Nov 7, 2023 · 03ccdef · 03ccdef
1 parent 020b4eb
commit 03ccdef
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/backend/core/src/email/email.service.ts b/backend/core/src/email/email.service.ts
@@ -350,7 +350,7 @@ export class EmailService {
 
     const compiled = compiledTemplate({
       listingName: listing.name,
-      listingUrl: jurisdiction.publicUrl,
+      listingUrl: `${jurisdiction.publicUrl}/listings/${listing.id}`,
       tableRows,
     })
 

diff --git a/backend/core/src/listings/listings.service.ts b/backend/core/src/listings/listings.service.ts
@@ -254,7 +254,16 @@ export class ListingsService {
       previousStatus !== ListingStatus.active &&
       jurisdiction.enableListingOpportunity
     ) {
-      await this.emailService.listingOpportunity(saveResponse)
+      // The email send to gov delivery should not be a blocker from the normal flow so wrapping this in a try catch
+      try {
+        const units = await this.getUnitsForListing(saveResponse.id)
+        await this.emailService.listingOpportunity({
+          ...saveResponse,
+          units: units.units,
+        } as Listing)
+      } catch (error) {
+        console.error(`Error: unable to send to govDelivery ${error}`)
+      }
     }
     return saveResponse
   }