Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to listing notification email #995

Open
sarahlazarich opened this issue Dec 11, 2024 · 10 comments
Open

Updates to listing notification email #995

sarahlazarich opened this issue Dec 11, 2024 · 10 comments
Assignees

Comments

@sarahlazarich
Copy link
Collaborator

sarahlazarich commented Dec 11, 2024

Doorway would like to add some language to the listing notification email

  • Add listing due time to new listing notification emails
  • Add a sentence in the email that says “Please refer to the listing for the most accurate information, as it is subject to change.”

AC:

  • The listing closure time is displayed on the email (in addition to the date)
  • New copy is displayed on the listing
  • Applicant receives emails in their preferred language, all strings are translated
  • Date and times on email blast are displayed in the email in PST
@ludtkemorgan
Copy link
Collaborator

Sample screenshot:
image

@sarahlazarich
Copy link
Collaborator Author

Placement of new line of copy TBD and needs to be approved by BAHFA
We have a template to work off of

@sarahlazarich
Copy link
Collaborator Author

Hard to test without access to govdelivery
Morgan will have to set that up for whoever is testing it, account is owned by BAHFA
Morgan can't add everyone to the UI but can add everyone to the distribution list

@jaredcwhite
Copy link
Collaborator

Looks like we don't have a unit test for this email, so I'm adding one to aid development as well as validate in automated tests.

@ludtkemorgan
Copy link
Collaborator

@sarahlazarich this has been merged and will soon be in Doorway staging.
You should be able to see the following after publishing a listing
image

@sarahlazarich
Copy link
Collaborator Author

Checking this out, the lottery time looks like it's not pulling correctly @jaredcwhite @ludtkemorgan

image.png

image.png

@ludtkemorgan
Copy link
Collaborator

@sarahlazarich good catch. The lottery date/time is saved in two separate fields and are only looking at the date field. I can update it as part of my bulk email change PR.

@jaredcwhite
Copy link
Collaborator

Ohh, dang. Sorry I missed that!

@sarahlazarich
Copy link
Collaborator Author

small thing @jaredcwhite and @ludtkemorgan - can we add a space into that lottery field between the year and "at"

image.png

@ludtkemorgan
Copy link
Collaborator

@sarahlazarich good catch. I made a fix for this in a new PR for bash findings and will go in before the release. #1043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants