Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add null check for csv export #1043

Merged
merged 3 commits into from
Jan 13, 2025
Merged

fix: add null check for csv export #1043

merged 3 commits into from
Jan 13, 2025

Conversation

ludtkemorgan
Copy link
Collaborator

@ludtkemorgan ludtkemorgan commented Jan 13, 2025

This PR addresses: This slack thread and This comment

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Due to bad data in staging there are a few listings where there is non applicant attached to applications. When a user attempts to export the applications for the listing these are tied to it crashes the backend.

This PR adds a null check to make sure if this data exists it won't break anything

Also there was a missing space in the updated content of the rental opportunity email

How Can This Be Tested/Reviewed?

Have an application and remove the applicant_id from it in the db. You should then be able to properly export the applications.

This is blocking the release so no tests have been created, but long term we should add tests for this functionality

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@ColinBuyck
Copy link
Collaborator

Is this aspect of this issue also blocking?
Screenshot 2025-01-13 at 11 46 37 AM

@ludtkemorgan ludtkemorgan force-pushed the fix/null-demographics branch from 7abff0c to 48e4166 Compare January 13, 2025 20:15
@ludtkemorgan ludtkemorgan force-pushed the fix/null-demographics branch from 48e4166 to f8ec77d Compare January 13, 2025 20:17
@ludtkemorgan
Copy link
Collaborator Author

@ColinBuyck that has been added!

@ColinBuyck
Copy link
Collaborator

ColinBuyck commented Jan 13, 2025

Got this error when trying to edit
Screenshot 2025-01-13 at 12 29 52 PM

Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧼 talked offline and null checks associated with editing the application will be handled in another ticket

@ColinBuyck ColinBuyck added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Jan 13, 2025
@ludtkemorgan ludtkemorgan merged commit 31ba98b into main Jan 13, 2025
16 checks passed
@ludtkemorgan ludtkemorgan deleted the fix/null-demographics branch January 13, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants