fix: add null check for csv export #1043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses: This slack thread and This comment
Description
Due to bad data in staging there are a few listings where there is non applicant attached to applications. When a user attempts to export the applications for the listing these are tied to it crashes the backend.
This PR adds a null check to make sure if this data exists it won't break anything
Also there was a missing space in the updated content of the rental opportunity email
How Can This Be Tested/Reviewed?
Have an application and remove the applicant_id from it in the db. You should then be able to properly export the applications.
This is blocking the release so no tests have been created, but long term we should add tests for this functionality
Author Checklist:
yarn generate:client
and/or created a migration when requiredReview Process: