Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch to Link component from Seeds on forgot password #1054

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

jaredcwhite
Copy link
Collaborator

This PR addresses #965

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This PR ensures the "Forgot password?" link on the username/password sign in flow retains whichever is the current locale.

How Can This Be Tested/Reviewed?

Check the link when attempting to sign in.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@jaredcwhite
Copy link
Collaborator Author

jaredcwhite commented Jan 17, 2025

Note: we'll want to backport this update to Bloom Core (even though this particular bug doesn't seem to be happening in Core).

Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mcgarrye mcgarrye added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Jan 22, 2025
@jaredcwhite jaredcwhite merged commit 7d451e2 into main Jan 23, 2025
16 checks passed
@jaredcwhite jaredcwhite deleted the 965/forgot-password-link-i18n branch January 23, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants