Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search field without flag #1070

Merged
merged 2 commits into from
Jan 27, 2025
Merged

fix: search field without flag #1070

merged 2 commits into from
Jan 27, 2025

Conversation

ColinBuyck
Copy link
Collaborator

This PR is a follow up from #972

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This PR adds the search field to the deprecated modal so that whether the new map is enabled or not, the search is functional.

How Can This Be Tested/Reviewed?

This can be tested by changing the SHOW_ALL_MAP_PINS flag to false and testing the search field in the modal.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@ColinBuyck ColinBuyck changed the title fix:search field without flag fix: search field without flag Jan 27, 2025
@emilyjablonski emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Jan 27, 2025
@ColinBuyck ColinBuyck merged commit 1205118 into main Jan 27, 2025
16 checks passed
@ColinBuyck ColinBuyck deleted the 972/search-without-flag branch January 27, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants