Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update sizes of clusters #1073

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Jan 29, 2025

This PR addresses #1074

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Following the map release, given the specific data set we have in production, we're less satisfied with the cluster sizes compared to what was in staging. The cluster sizes feel as though they are not big enough compared to a single pin, and there's not enough disparity between clusters of different numbers. Google has a few different algorithms you can use for clustering.

I updated some settings on one of their algorithms and increased slightly both the size and disparity between clusters.

How Can This Be Tested/Reviewed?

This has been approved w design.

This PR with updated cluster algorithm and slightly larger size and disparity:
Screenshot 2025-01-29 at 8 28 38 AM
Production:
Screenshot 2025-01-29 at 8 28 44 AM

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@emilyjablonski emilyjablonski marked this pull request as ready for review January 29, 2025 16:01
Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧼

@ColinBuyck ColinBuyck added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Jan 30, 2025
@emilyjablonski emilyjablonski merged commit 16399ec into main Jan 30, 2025
16 checks passed
@emilyjablonski emilyjablonski deleted the improve-clustering-icons branch January 30, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants