Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Upgrade various github actions to supported versions #471

Merged
merged 5 commits into from
Feb 11, 2024

Conversation

gbbayareametro
Copy link

@gbbayareametro gbbayareametro commented Feb 5, 2024

Pull Request Template

Issue Overview

Assigning to @ludtkemorgan
This PR addresses #issue

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

  • Upgrade codeql to V2 (v1 is deprecated)
  • Minor formatting changes

How Can This Be Tested/Reviewed?

Github action should be successful

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • [NA] I have reviewed the changes in a desktop view
  • [NA] I have reviewed the changes in a mobile view
  • [NA] I have commented my code, particularly in hard-to-understand areas
  • [NA] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [NA] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • [NA] Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • [NA] I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • [NA] My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • [NA] Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@ludtkemorgan ludtkemorgan added the ready to merge Should be applied when a PR has been reviewed and approved label Feb 10, 2024
@ludtkemorgan
Copy link
Collaborator

@gbbayareametro this looks good. Feel free to squash and merge this. Just note we use conventional commits so make sure you change the commit message before clicking the "confirm squash and merge" button

@gbbayareametro gbbayareametro changed the title Feat/codeqlv2 Feat: Upgrade various github actions to supported versions Feb 11, 2024
@gbbayareametro gbbayareametro merged commit 5a45e1a into main Feb 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants