Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github Action Plugins. #473

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Conversation

gbbayareametro
Copy link

@gbbayareametro gbbayareametro commented Feb 5, 2024

Pull Request Template

Issue Overview

This PR addresses #issue

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

  • Integrated Trunk Linter wrapper along with several linters
  • Fixed open issues found by the linter. Almost entirely in the Github actions

How Can This Be Tested/Reviewed?

Github actions alone should be enough. If you want to test it out, install trunk and run "trunk check --all" or use the VSCode extension

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

Copy link

cypress bot commented Feb 6, 2024

3 failed tests on run #14 ↗︎

3 47 1 0 Flakiness 0

Details:

Merge 3e1e387 into 9e6c0b4...
Project: Doorway Cypress Public Commit: fb5f441863 ℹ️
Status: Failed Duration: 07:25 💡
Started: Feb 6, 2024 7:39 PM Ended: Feb 6, 2024 7:46 PM
Failed  navigation.spec.ts • 1 failed test

View Output Video

Test Artifacts
Site navigation > should load the listings page Screenshots Video
Failed  pages/submit-application.spec.ts • 2 failed tests

View Output Video

Test Artifacts
Submit > should submit an application for the Test: Coliseum listing Screenshots Video
Submit > should submit a minimal application for the Test: Default, No Preferences Screenshots Video

Review all test suite changes for PR #473 ↗︎

@gbbayareametro gbbayareametro marked this pull request as ready for review February 6, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant