Parallel Unstructured Mesh Infrastructure (PUMI): Attaching Gmsh Physical Entity Tags [cws/pumi-gmsh-phys-ents]

[cwsmith]

This PR adds support for attaching Gmsh physical entity tags stored in PUMI meshes as an attribute on an MFEM mesh. See issue #2726 for development and testing discussion.

This PR is backward compatible with PUMI meshes created with PUMI <= 2.2.6, but only PUMI meshes created with the upcoming PUMI 2.2.7 release or the current master@19185e9 branch will contain the Gmsh physical entity tags.

PR	Author	Editor	Reviewers	Assignment	Approval	Merge
#2782	@cwsmith	@tzanio	@tzanio + @mlstowell	01/27/22	02/01/22	02/08/22

[tzanio]

@cwsmith, please mark as ready-for-review when this is ready.

(see https://github.com/mfem/mfem/blob/master/CONTRIBUTING.md#quick-summary)

[tzanio]

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

[tzanio]

Thanks @cwsmith !

[tzanio]

Merged in next for testing...

[tzanio]

Can you fix the style please: https://github.com/mfem/mfem/runs/5023713810?check_suite_focus=true#step:4

(the code-style CI check above didn't run because the PR is from a fork)

[cwsmith]

@tzanio The style should be fixed with 69c9160. I'll be sure to create branches in the mfem repo for future PRs.

[tzanio]

Thanks @cwsmith !

[v-dobrev]

Hi @cwsmith, our nighly tests uncovered a build issue with PUMI v2.2.6:

ex1p.cpp:152:29: error: invalid conversion from 'const ma::Input*' to 'ma::Input*' [-fpermissive]
          crv::adapt(uniInput);
                             ^

Is it possible to change the PR to keep it compatible with PUMI v2.2.6, or should we consider PUMI v2.2.7 to be the new minimum version requirement for PUMI? Maybe we can use auto when defining uniInput? I'm not sure about the other code changes.

[cwsmith]

@v-dobrev Commit a88269f using auto was just pushed. Thanks for the suggestion. This should restore compatibility with PUMI 2.2.6.

I'm fine with supporting a small range of minor PUMI versions or increasing the minimum required version. PUMI 2.2.7 should be released in late February (... after SIAM PP22). Do you have a preference?

[v-dobrev]

Thanks, @cwsmith!

Let's keep the required PUMI version at 2.2.6 since 2.2.7 is not released yet.

Actually, right now the required version is listed as PUMI == 2.2.3:

mfem/INSTALL

Line 707 in a96065e

Versions: PUMI == 2.2.3.

We should update this accordingly: either PUMI >= 2.2.3, PUMI >= 2.2.6, or something like that.

[cwsmith]

@v-dobrev You're welcome. The minimum pumi version listed in the INSTALL file was increased to 2.2.6 in fb41c29 and 606ba7c increased the minimum version in CMakeLists.txt.

I didn't see a version check mechanism in the makefile based build system. Did I miss it (I didn't dig too deep)?

[v-dobrev]

I didn't see a version check mechanism in the makefile based build system. Did I miss it (I didn't dig too deep)?

No, there is no version check in the GNU make build system.

Also, there were no issues in the nightly tests with the latest commit, so this should be ready to be merged.