feat(sarif): adjust end column

Both SARIF and diagnostic-structure are exclusive ranges.
mfussenegger · Jan 7, 2025 · d5e1e5b · d5e1e5b
1 parent aec22a3
commit d5e1e5b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/lua/lint/parser.lua b/lua/lint/parser.lua
@@ -142,7 +142,7 @@ function M.for_sarif(skeleton, opts)
                   lnum = region.startLine - 1,
                   end_lnum = region.endLine and region.endLine - 1,
                   col = region.startColumn and region.startColumn - 1 or 0,
-                  end_col = region.endColumn and region.endColumn - 2 or default_end_col,
+                  end_col = region.endColumn and region.endColumn - 1 or default_end_col,
                   severity = severity,
                   message = message,
                   source = source,

diff --git a/spec/pmd_spec.lua b/spec/pmd_spec.lua
@@ -137,7 +137,7 @@ describe("linter.pmd", function()
         lnum = 0,
         end_lnum = 0,
         col = 0,
-        end_col = 4,
+        end_col = 5,
         severity = vim.diagnostic.severity.WARN,
         message = "All classes, interfaces, enums and annotations must belong to a named package",
         source = "PMD",
@@ -149,7 +149,7 @@ describe("linter.pmd", function()
         lnum = 0,
         end_lnum = 0,
         col = 0,
-        end_col = 4,
+        end_col = 5,
         severity = vim.diagnostic.severity.ERROR,
         message = "The class name 'foo' doesn't match '[A-Z][a-zA-Z0-9]*'",
         source = "PMD",

diff --git a/spec/sarif_spec.lua b/spec/sarif_spec.lua
@@ -466,7 +466,7 @@ describe("parser.sarif", function()
         bufnr = 1,
         lnum = 0,
         col = 9,
-        end_col = 18,
+        end_col = 19,
         severity = vim.diagnostic.severity.WARN,
         message = "This is a placeholder message.",
         source = "SpecTool",
@@ -842,7 +842,7 @@ describe("parser.sarif", function()
         bufnr = 1,
         lnum = 0,
         col = 9,
-        end_col = 18,
+        end_col = 19,
         severity = vim.diagnostic.severity.WARN,
         message = "This is a placeholder message.",
         source = "SpecTool",