fix: normalize paths before comparing equality #513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Although this is a small change, it makes a big difference in usability for me. Is there anything I can do to get this ready for review? |
Fix consistency issues on Windows when some linters use a single backslash, some use a double (escaped) backslash, and some still use a forward slash. This fix is confirmed to fix issues with Mypy on Windows, and it probably affects other linters as well. Fixes #480.
|
Thanks. Added a small fixup to maintain compatibility with older neovim versions and merged via #539 For the future please use a feature branch. I cannot ammend to PRs created from master. |
|
Understood. I apologize - I thought forking the repo counted my master as being a feature. I appreciate you looking at this and merging the fix. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix consistency issues on Windows when some linters use a single backslash, some use a double (escaped) backslash, and some still use a forward slash.
This fix is confirmed to fix issues with Mypy on Windows, and it probably affects other linters as well.
Fixes #480.