Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graylint adapter #740

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

noelevans
Copy link

Python has a linter called graylint. The tool uses other linters to assess the code (pylint, mypy, flake8) but then only flags lines that are new to git. Graylint returns line-by-line lint issues rather than json or other alternatives used by pylint.

Python has a linter called graylint. The tool uses other linters to
assess the code (pylint, mypy, flake8) but then only flags lines that
are new to git. Graylint returns line-by-line lint issues rather than
json or other alternatives used by pylint.
@noelevans
Copy link
Author

Thinking about this change more, I see that I'm hardcoding Graylint to the Pylint. Looking more at Ruff I see that it has many benefits over Pylint (which still seems to be the more established of the options Graylint can run). What is the best thing to do? Should I label this linter as graylint-pylint and make another for graylint-ruff? Graylint is also able to run mypy and flake8 internally too. What approach do you prefer @mfussenegger?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant