Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripting: add signed/unsigned read/write functions #3024

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ahigerd
Copy link
Contributor

@ahigerd ahigerd commented Sep 17, 2023

After discussion with Icesythe7, I decided to just take the initiative to add signed versions of the memory functions.

@endrift
Copy link
Member

endrift commented Feb 17, 2025

So the reason I haven't merged this--or really taken care of any of the other signed/unsigned discrepancies is bikeshedding. I'm not sure how I want everything to be handled, but I want it consistent across the API. I don't really like the idea of signed/unsigned versions of every read, but the alternative is unifying them as probably unsigned and adding a utility function for converting between them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants