Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feats: devenv / update deps / clean clippy / dependabot / drop useless submodule #134

Closed
wants to merge 2 commits into from

Conversation

kioqq
Copy link

@kioqq kioqq commented Feb 5, 2025

Hi @mgeier, I've been using your library for a while through my private fork and thought I'd share what I have. Maybe it will be useful in some way for you.

  • drop useless submodule
  • update dev deps
  • clean clippy after update
  • dependabot for looking dev-deps updates
  • devenv/justfile for better new devs experience :)

@kioqq kioqq changed the title feat: devenv + update deps + clean clippy + dependabot feats: devenv + update deps + clean clippy + dependabot + drop useless submodule Feb 5, 2025
@kioqq kioqq changed the title feats: devenv + update deps + clean clippy + dependabot + drop useless submodule feats: devenv / update deps / clean clippy / dependabot / drop useless submodule Feb 5, 2025
@mgeier
Copy link
Owner

mgeier commented Feb 5, 2025

Thanks for this PR!

It looks like this consists of multiple independent changes, right?

It would be easier for me to review if you could split it into multiple PRs, ideally starting with smaller ones.

drop useless submodule

I don't think it's useless. It allows us get changes from the upstream project, there's even a GitHub action that sends a notification when something changes: https://github.com/mgeier/rtrb/blob/main/.github/workflows/cache-padded-updates.yml

When we copy the file into this repo, it will get outdated.

Or am I missing something?

devenv/justfile for better new devs experience :)

I'm not familiar with either of those tools, so I'll have to look into it before I can determine whether those changes are worth making.

At first sight, it sure looks like a lot of boilerplate.

@kioqq
Copy link
Author

kioqq commented Feb 6, 2025

I just thought I'd share how I use your crate by myself, nothing more :) If you want to take something from it I can make a separate PR or you can do it yourself.

@kioqq kioqq closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants