Skip to content
This repository has been archived by the owner on May 12, 2018. It is now read-only.

Commit

Permalink
v0.0.2 - test with python2 and python3
Browse files Browse the repository at this point in the history
  • Loading branch information
mgk committed Aug 1, 2015
1 parent 00c239b commit 7e69322
Show file tree
Hide file tree
Showing 8 changed files with 24 additions and 10 deletions.
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ sudo: false
language: python

python:
- 3.3
- 3.4
- 3.3
- 2.7

services:
- redis-server
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
## [0.0.1] - 2015-08-01
### Added
- Initial release.

## [0.0.2] - 2015-08-01
### Added
- Test with Python 2.7, 3.3, and 3.4.
1 change: 1 addition & 0 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
pytest
pep8
coveralls
mock
rq-scheduler>=0.5.1
2 changes: 1 addition & 1 deletion rq_retry/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
from .worker import RetryWorker

__version__ = '0.0.1'
__version__ = '0.0.2'
2 changes: 1 addition & 1 deletion rq_retry/queue.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class DeadLetterQueue(Queue):
of dead letter queues.
"""
def __init__(self, name, connection):
super().__init__(name=name, connection=connection)
super(DeadLetterQueue, self).__init__(name=name, connection=connection)

def quarantine(self, job, queue):
"""Moves job from the specified queue to the dead letter queue"""
Expand Down
11 changes: 6 additions & 5 deletions rq_retry/worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,15 @@ class RetryWorker(Worker):
*Environment variable*: `RQ_RETRY_DEAD_LETTER_QUEUE`
*Default*: 'dead_letter_queue'
"""
def __init__(self, *args, retry_config={}, **kwargs):

def __init__(self, *args, **kwargs):
default_config = dict(
maint_interval=timedelta(seconds=30),
max_tries=3,
delays=[5],
dead_letter_queue='dead_letter_queue')

retry_config = kwargs.pop('retry_config', {})

self.apply_config(retry_config, default_config)
if not isinstance(self.maint_interval, timedelta):
self.maint_interval = timedelta(seconds=float(self.maint_interval))
Expand All @@ -79,7 +80,7 @@ def __init__(self, *args, retry_config={}, **kwargs):
except ValueError:
self.delays = []

super().__init__(*args, **kwargs)
super(RetryWorker, self).__init__(*args, **kwargs)
self._dead_letter_queue = DeadLetterQueue(self.dead_letter_queue,
connection=self.connection)

Expand All @@ -99,7 +100,7 @@ def register_birth(self):
'dead_letter_queue']:
self.log.info('{} = {}'.format(p, getattr(self, p)))
self.log.info('Use RQ Scheduler? {}'.format(self.use_scheduler))
super().register_birth()
super(RetryWorker, self).register_birth()

@property
def use_scheduler(self):
Expand All @@ -113,7 +114,7 @@ def should_run_maintenance_tasks(self):
)

def clean_registries(self):
super().clean_registries()
super(RetryWorker, self).clean_registries()
self.retry_failed_jobs()

def retry_failed_jobs(self):
Expand Down
4 changes: 3 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def run_tests(self):

setup(
name='rq-retry',
version='0.0.1',
version='0.0.2',
description='RQ retry worker and dead letter queue',
long_description=__doc__,
url='https://github.com/mgk/rq-retry',
Expand Down Expand Up @@ -54,6 +54,8 @@ def run_tests(self):
'Topic :: System :: Systems Administration',
'Topic :: System :: Monitoring',

'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.3',
'Programming Language :: Python :: 3.4',
Expand Down
7 changes: 6 additions & 1 deletion tests/test_retry_worker.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import pytest
from unittest.mock import patch, Mock

try:
from unittest.mock import patch, Mock
except ImportError:
from mock import patch, Mock

import os
import logging
from datetime import timedelta
Expand Down

0 comments on commit 7e69322

Please sign in to comment.