-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seperate core and contrib api files #774
base: main
Are you sure you want to change the base?
Conversation
…ontribDeprecatedHooksInApiFiles: bool
…w parameters are set based on old one
…d the api.php files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me (I'm still a proponent of immediately setting checkCoreDeprecatedHooksInApiFiles
to true
but I know Matt wants to do it in a separate minor release).
Commenting rather than explicitly approving because I don't know if we can already remove checkCoreDeprecatedHooksInApiFiles
anywhere. For example from bleedingEdge.neon
, in order to prevent people from getting deprecation notices for something they load from the package itself.
Not entirely sure what the difference in behaviour between bleedingEdge.neon
and extension.neon
is though (since the values also differ in those two files).
// Trigger deprecation error if checkDeprecatedHooksInApiFiles is enabled. | ||
if ($drupalParams['bleedingEdge']['checkDeprecatedHooksInApiFiles']) { | ||
trigger_error('The bleedingEdge.checkDeprecatedHooksInApiFiles parameter is deprecated and will be removed in a future release.', E_USER_DEPRECATED); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah this is how
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just missing version, but that's OK I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated bleedingedge so when people copy that they won't get a deprecation notice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might need an isset or something when we remove the setting? Or perhaps even now.
Good point about bleeding edge. Updated |
Fixes #770