WIP: svelte5 port #305
Open
WIP: svelte5 port #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of carbon components supports svelte 5
Reference screenshots will still need to be updated
The new version of carbon components fixes a small layout missalignment for the toolbar buttons
This should fix the insert sheet regression
This reverts commit f60eaac.
Allows keyboard to be made reactive. Needed for the selectedTab property
This was the wrong place to put the reactivity
Has some performance improvements over prevoius version
Brakes other things, all cell types will need to be ported before all tests will pass. Having non-runes and runes components access the same stores causes reactivity issues for the non-runes components.
Change $effect to $derived.by
Test also added
Test also added
This will facilitate moving from stores to runes for app state
Some warnings need to be addressed and there is an issue with setting custom units which is possibly rated to using a store for the custom base units sheet setting
There are some issues with stores and reactivity in runes mode, especially with binding
Need to access state in keyboard.ts
Work around required for stores is no longer required using $state
Workaround required for stores Writable no longer required for $state driven app wide state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires latest carbon svelte components