Make legend artists case-insensitive

Move to ES classes for backbone extending, which found some type errors. Fix a type error (array.size() does not exist) in num_requests_pending.
mhansen · Jan 1, 2025 · d7fddc3 · d7fddc3
1 parent 440f67a
commit d7fddc3
Show file tree

Hide file tree

Showing 30 changed files with 250 additions and 169 deletions.
diff --git a/public/AppController.js b/public/AppController.js
@@ -1,8 +1,8 @@
-let appModel = new AppModel;
-let fetchModel = new FetchModel;
-let graphViewModel = new FlotScrobbleGraphViewModel;
-let legendModel = new LegendModel;
-let scrobbleCollection = new ScrobbleCollection;
+let appModel = new AppModel();
+let fetchModel = new FetchModel();
+let graphViewModel = new FlotScrobbleGraphViewModel();
+let legendModel = new LegendModel();
+let scrobbleCollection = new ScrobbleCollection();
 let requestQueue = new RequestQueue({
     max_n_reqs_in_progress: 4
 });

diff --git a/public/models/AppModel.js b/public/models/AppModel.js
@@ -1,12 +1,16 @@
 // Global state that I couldn't find a more specific place for
 // It's all used to form the path of the URL.
-const AppModel = Backbone.Model.extend({
-    user() { return this.get("user"); },
+class AppModel extends Backbone.Model {
+    user() {
+        return this.get("user");
+    }
     initialize() {
         this.set({ user: null });
         this.set({ filterTerm: "" });
-    },
-    filterRegex() { return new RegExp(this.get("filterTerm"), "i"); },
+    }
+    filterRegex() {
+        return new RegExp(this.get("filterTerm"), "i");
+    }
     validate(attrs) {
         try {
             new RegExp(attrs.filterTerm, "i");
@@ -16,4 +20,4 @@ const AppModel = Backbone.Model.extend({
             return `Whoops! That's not a regular expression: ${error}`;
         }
     }
-});
+}
diff --git a/public/models/FetchModel.js b/public/models/FetchModel.js
@@ -1,13 +1,13 @@
-const FetchModel = Backbone.Model.extend({
+class FetchModel extends Backbone.Model {
     initialize() {
         this.set({
             pagesFetched: [],
             totalPages: 0,
             lastPageFetched: 0,
             isFetching: false
         });
-    },
-    numPagesFetched() { return this.get("pagesFetched").length; },
+    }
+    numPagesFetched() { return this.get("pagesFetched").length; }
     fetch_scrobbles(username) {
         if (!username) {
             throw "Invalid Username";
@@ -65,4 +65,4 @@ const FetchModel = Backbone.Model.extend({
             })();
         });
     }
-});
+}
diff --git a/public/models/LegendModel.js b/public/models/LegendModel.js
@@ -15,27 +15,33 @@ const LEGEND_COLORS = [
     '#b15928',
     '#ffff99',
 ];
-const LegendModel = Backbone.Model.extend({
+class ArtistColor {
+}
+class LegendModel extends Backbone.Model {
     initialize() {
         this.set({ artistColors: {} });
-    },
+    }
+    get_artist_color(artist) {
+        return this.get('artistColors').get(artist.toLowerCase());
+    }
     compute_artist_colors(scrobbles) {
         let a = _.chain(scrobbles.models)
-            .groupBy(s => s.artist())
+            .groupBy(s => s.artist().toLowerCase())
             .toArray()
             .sortBy('length')
             .reverse()
             .value();
-        let artistColors = {};
+        let artistColors = new Map();
         const otherColor = LEGEND_COLORS[0];
         for (let i = 0; i < a.length; i++) {
             let x = a[i];
-            artistColors[x[0].artist()] = {
+            artistColors.set(x[0].artist().toLowerCase(), {
+                artist: x[0].artist(),
                 color: LEGEND_COLORS[i + 1] || otherColor,
                 count: x.length,
                 showInLegend: !!LEGEND_COLORS[i + 1],
-            };
+            });
         }
         this.set({ artistColors, otherColor });
     }
-});
+}
diff --git a/public/models/Request.js b/public/models/Request.js
@@ -1,4 +1,4 @@
-const LastFMRequest = Backbone.Model.extend({
+class LastFMRequest extends Backbone.Model {
     run() {
         return $.ajax({
             url: "https://ws.audioscrobbler.com/2.0/",
@@ -30,4 +30,4 @@ const LastFMRequest = Backbone.Model.extend({
             dataType: "jsonp" //, timeout: 20000. Timeout error handling is flawed.
         });
     }
-});
+}
diff --git a/public/models/RequestQueue.js b/public/models/RequestQueue.js
@@ -5,17 +5,18 @@
 // rate limited, but not as often, and the rate limiting goes away after a few
 // seconds.
 const rate_limit_ms = 500;
-const RequestQueue = Backbone.Model.extend({
-    initialize() {
+class RequestQueue extends Backbone.Model {
+    constructor() {
+        super(...arguments);
         this.queue = [];
         this.currentlyEmptyingQueue = false;
-    },
+    }
     add(req) {
         this.queue.push(req);
         if (!this.currentlyEmptyingQueue) {
             this.doAnotherRequest();
         }
-    },
+    }
     doAnotherRequest() {
         if (this.queue.length === 0) {
             this.currentlyEmptyingQueue = false;
@@ -28,8 +29,8 @@ const RequestQueue = Backbone.Model.extend({
                 this.doAnotherRequest();
             }, rate_limit_ms);
         }
-    },
+    }
     numReqsPending() {
-        return this.queue.size();
+        return this.queue.length;
     }
-});
+}
diff --git a/public/models/ScrobbleCollection.js b/public/models/ScrobbleCollection.js
@@ -1,12 +1,15 @@
-const Scrobble = Backbone.Model.extend({
-    artist() { return this.get("artist"); },
-    album() { return this.get("album"); },
-    track() { return this.get("track"); },
-    date() { return this.get("date"); },
+class Scrobble extends Backbone.Model {
+    artist() { return this.get("artist"); }
+    album() { return this.get("album"); }
+    track() { return this.get("track"); }
+    date() { return this.get("date"); }
     image() { return this.get("image"); }
-});
-const ScrobbleCollection = Backbone.Collection.extend({
-    model: Scrobble,
+}
+class ScrobbleCollection extends Backbone.Collection {
+    constructor() {
+        super(...arguments);
+        this.model = Scrobble;
+    }
     add_from_lastfm_json(json) {
         for (let scrobble of json.recenttracks.track) {
             // Pull out just the information we need, because memory has been known
@@ -35,4 +38,4 @@ const ScrobbleCollection = Backbone.Collection.extend({
             this.add(my_scrobble, { silent: true });
         }
     }
-});
+}
diff --git a/public/views/DrawingThrobberView.js b/public/views/DrawingThrobberView.js
@@ -1,4 +1,4 @@
-const DrawingThrobberView = Backbone.View.extend({
+class DrawingThrobberView extends Backbone.View {
     render() {
         if (graphViewModel.get("isDrawing")) {
             $("#drawingThrobber").show();
@@ -7,7 +7,8 @@ const DrawingThrobberView = Backbone.View.extend({
         else {
             $("#drawingThrobber").hide();
         }
+        return this;
     }
-});
-const drawingThrobberView = new DrawingThrobberView;
+}
+const drawingThrobberView = new DrawingThrobberView();
 graphViewModel.on("change:isDrawing", (model, isDrawing) => drawingThrobberView.render());
diff --git a/public/views/FetchThrobberView.js b/public/views/FetchThrobberView.js
@@ -1,5 +1,4 @@
-const FetchThrobberView = Backbone.View.extend({
-    el: "#fetchThrobber",
+class FetchThrobberView extends Backbone.View {
     render() {
         if (fetchModel.get("isFetching")) {
             let n = fetchModel.numPagesFetched();
@@ -11,9 +10,12 @@ const FetchThrobberView = Backbone.View.extend({
         else {
             this.$el.hide();
         }
+        return this;
     }
+}
+const fetchThrobberView = new FetchThrobberView({
+    el: "#fetchThrobber",
 });
-const fetchThrobberView = new FetchThrobberView;
 fetchModel.on("newPageFetched", () => fetchThrobberView.render());
 fetchModel.on("change:isFetching", function (model) {
     if (model.get("isFetching")) {

diff --git a/public/views/FilterBoxView.js b/public/views/FilterBoxView.js
@@ -1,14 +1,23 @@
-const FilterBoxView = Backbone.View.extend({
-    el: "#searchForm",
-    render(isDrawn) {
-        if (isDrawn) {
+class FilterBoxView extends Backbone.View {
+    constructor() {
+        super(...arguments);
+        this.isDrawn = false;
+    }
+    render() {
+        if (this.isDrawn) {
             this.$el.fadeIn(1000);
         }
         else {
             this.$el.hide();
         }
-    },
+        return this;
+    }
     val() { return $("#search").val(); }
+}
+const filterBoxView = new FilterBoxView({
+    el: "#searchForm",
+});
+graphViewModel.on("change:isDrawn", (model, isDrawn) => {
+    filterBoxView.isDrawn = isDrawn;
+    filterBoxView.render();
 });
-const filterBoxView = new FilterBoxView;
-graphViewModel.on("change:isDrawn", (model, isDrawn) => filterBoxView.render(isDrawn));
diff --git a/public/views/FlashingScrobbleView.js b/public/views/FlashingScrobbleView.js
@@ -1,5 +1,7 @@
-const FlashingScrobbleView = Backbone.View.extend({
-    initialize() { this.flashingTimer = null; },
+class FlashingScrobbleView extends Backbone.View {
+    initialize() {
+        this.flashingTimer = null;
+    }
     render(scrobble) {
         if (this.flashingTimer != null) {
             clearInterval(this.flashingTimer);
@@ -15,7 +17,8 @@ const FlashingScrobbleView = Backbone.View.extend({
             }
         };
         this.flashingTimer = setInterval(flash, 200);
-    },
+        return this;
+    }
     remove() {
         if (this.flashingTimer != null) {
             clearInterval(this.flashingTimer);
@@ -24,9 +27,10 @@ const FlashingScrobbleView = Backbone.View.extend({
         if (window.plot != null) {
             window.plot.unhighlight();
         }
+        return this;
     }
-});
-const flashingScrobbleView = new FlashingScrobbleView;
+}
+const flashingScrobbleView = new FlashingScrobbleView();
 $("#flot_container").on("plothover plotclick", function (event, pos, item) {
     if (item) { // we're hovering over an data point
         flashingScrobbleView.render(item.series.scrobble);

diff --git a/public/views/FlotScrobbleGraphView.js b/public/views/FlotScrobbleGraphView.js
@@ -1,4 +1,4 @@
-const FlotScrobbleGraphView = Backbone.View.extend({
+class FlotScrobbleGraphView extends Backbone.View {
     render() {
         if (scrobbleCollection.size() === 0) {
             return;
@@ -9,17 +9,20 @@ const FlotScrobbleGraphView = Backbone.View.extend({
         setTimeout(function () {
             legendModel.compute_artist_colors(scrobbleCollection);
             let re = appModel.filterRegex();
-            let filtered_scrobbles = scrobbleCollection.filter(s => re.exec(s.track()) || re.exec(s.artist()) || re.exec(s.album()));
+            let filtered_scrobbles = scrobbleCollection.filter(s => re.exec(s.track()) != null ||
+                re.exec(s.artist()) != null ||
+                re.exec(s.album()) != null);
             let flot_series = construct_flot_series(filtered_scrobbles);
             let minTime = scrobbleCollection.min(scrobble => scrobble.date()).date();
             let maxTime = scrobbleCollection.max(scrobble => scrobble.date()).date();
             plot_flot_series(flot_series, minTime, maxTime);
             graphViewModel.set({ isDrawn: true, isDrawing: false });
         }, 0);
+        return this;
     }
-});
+}
 var construct_flot_series = function (scrobbles) {
-    window.track_indices = {
+    const track_indices = window['track_indices'] = {
     // Here's an example:
     //"snow patrol#eyes open": {
     //series_index: 1
@@ -31,7 +34,7 @@ var construct_flot_series = function (scrobbles) {
         let date = scrobble.date().getTime();
         let time = scrobble.date().getHours() + (scrobble.date().getMinutes() / 60);
         series.push({
-            color: legendModel.get("artistColors")[scrobble.artist()].color,
+            color: legendModel.get_artist_color(scrobble.artist()).color,
             data: [[date, time]],
             scrobble
         });
@@ -47,7 +50,9 @@ var construct_flot_series = function (scrobbles) {
 };
 var plot_flot_series = function (flot_series, minTime, maxTime) {
     let ONE_DAY_IN_MS = 1000 * 60 * 60 * 24;
-    plot = $.plot($("#flot_container"), flot_series, {
+    // Don't have types for this old version of flot.
+    // @ts-ignore
+    window['plot'] = $.plot($("#flot_container"), flot_series, {
         xaxis: {
             min: minTime,
             max: maxTime,
@@ -93,7 +98,7 @@ var plot_flot_series = function (flot_series, minTime, maxTime) {
         }
     });
 };
-let flotScrobbleGraphView = new FlotScrobbleGraphView;
+let flotScrobbleGraphView = new FlotScrobbleGraphView();
 let redraw_on_response_number = 1;
 appModel.on("change:user", () => redraw_on_response_number = 1);
 fetchModel.on("newPageFetched", function () {

diff --git a/public/views/LegendView.js b/public/views/LegendView.js
@@ -1,13 +1,11 @@
-const LegendView = Backbone.View.extend({
-    el: "#legend_wrap",
+class LegendView extends Backbone.View {
     render() {
         this.$("li").remove();
         let artistColors = legendModel.get("artistColors");
-        for (let artist in artistColors) {
-            let color = artistColors[artist];
+        for (const color of artistColors.values()) {
             if (color.showInLegend) {
                 $("<li>")
-                    .text(`${artist} (${color.count})`)
+                    .text(`${color.artist} (${color.count})`)
                     .css("color", color.color)
                     .appendTo("#legend");
             }
@@ -17,10 +15,14 @@ const LegendView = Backbone.View.extend({
             .css("color", legendModel.get("otherColor"))
             .appendTo("#legend");
         this.$el.show();
-    },
+        return this;
+    }
     remove() {
         this.$el.hide();
+        return this;
     }
+}
+const legendView = new LegendView({
+    el: "#legend_wrap",
 });
-const legendView = new LegendView;
 legendModel.on("change:artistColors", (model, artistColors) => legendView.render());