DragOvering the DraggableObject from one SortableObjects to another not working properly. #212 #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s that it is not working properly when drag drops from one list to another list.
Issue while drag and drop to multiple list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When dragging the object and dragOvering to another list. It was added to the new list even without dropping the item. And not able to shift that item without dropping the currentDragItem. Then I need to drop the current item, drag and dragover the object again to shift the object.
The reason is,
const hasSameSortingScope = this. get('currentDragItem.sortingScope ') === emberObject.get('sortingScope');
this.get return undefined in this chain path.
sol:
const hasSameSortingScope = this. get('currentDragItem').sortingScope === emberObject.get('sortingScope');
or
const hasSameSortingScope = this.currentDragItem.sortingScope === emberObject.sortingScope;
Hopefully, it will not change other behaviors.